Bug 202325 – [Win] Crash under FontCache::lastResortFallbackFont

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Per Arne Vollan]

Backtrace:

 	WebKit.dll!WebCore::FontCache::lastResortFallbackFont(const WebCore::FontDescription & fontDescription) Line 393	C++	Symbols loaded.
	WebKit.dll!WebCore::FontCascadeFonts::realizeFallbackRangesAt(const WebCore::FontCascadeDescription & description, unsigned int index) Line 188	C++	Symbols loaded.
 	[Inline Frame] WebKit.dll!WebCore::FontCascadeFonts::primaryFont(const WebCore::FontCascadeDescription & description) Line 128	C++	Symbols loaded.
 	[Inline Frame] WebKit.dll!WebCore::FontCascade::primaryFont() Line 337	C++	Symbols loaded.
 	WebKit.dll!WebCore::StyleResolver::StyleResolver(WebCore::Document & document) Line 227	C++	Symbols loaded.
 	[Inline Frame] WebKit.dll!std::make_unique(WebCore::Document & <_Args_0>) Line 2539	C++	Symbols loaded.
 	WebKit.dll!WebCore::Style::Scope::resolver() Line 100	C++	Symbols loaded.
 	[Inline Frame] WebKit.dll!WebCore::Style::TreeResolver::Scope::{ctor}(WebCore::Document & document) Line 67	C++	Symbols loaded.
 	WebKit.dll!WebCore::Style::TreeResolver::resolve() Line 544	C++	Symbols loaded.
 	WebKit.dll!WebCore::Document::resolveStyle(WebCore::Document::ResolveStyleType type) Line 1938	C++	Symbols loaded.
 	WebKit.dll!WebCore::Document::updateStyleIfNeeded() Line 2082	C++	Symbols loaded.
 	WebKit.dll!WebCore::Document::finishedParsing() Line 5756	C++	Symbols loaded.
 	[Inline Frame] WebKit.dll!WebCore::HTMLDocumentParser::end() Line 427	C++	Symbols loaded.
 	[Inline Frame] WebKit.dll!WebCore::HTMLDocumentParser::attemptToRunDeferredScriptsAndEnd() Line 436	C++	Symbols loaded.
 	WebKit.dll!WebCore::HTMLDocumentParser::prepareToStopParsing() Line 142	C++	Symbols loaded.
 	[Inline Frame] WebKit.dll!WebCore::HTMLDocumentParser::attemptToEnd() Line 448	C++	Symbols loaded.
 	WebKit.dll!WebCore::HTMLDocumentParser::finish() Line 476	C++	Symbols loaded.
 	WebKit.dll!WebCore::DocumentWriter::end() Line 289	C++	Symbols loaded.
 	WebKit.dll!WebCore::DocumentLoader::finishedLoading() Line 446	C++	Symbols loaded.
 	WebKit.dll!WebCore::DocumentLoader::maybeLoadEmpty() Line 1715	C++	Symbols loaded.
 	WebKit.dll!WebCore::DocumentLoader::startLoadingMainResource() Line 1728	C++	Symbols loaded.
 	WebKit.dll!WebCore::FrameLoader::init() Line 315	C++	Symbols loaded.
 	WebKit.dll!WebView::initWithFrame(tagRECT frame, wchar_t * frameName, wchar_t * groupName) Line 3160	C++	Symbols loaded.

[Per Arne Vollan]

Created attachment 379746 [details]
Patch

[Per Arne Vollan]

<rdar://problem/47856730>

[Per Arne Vollan]

Created attachment 379748 [details]
Patch

[Brent Fulgham]

Comment on attachment 379748 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379748&action=review

Thank's for tracking this down.

> Source/WebCore/platform/graphics/win/FontCacheWin.cpp:-398
> -    return *simpleFont;

Oh no!

[Per Arne Vollan]

(In reply to Brent Fulgham from comment #4)
> Comment on attachment 379748 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=379748&action=review
> 
> Thank's for tracking this down.
> 
> > Source/WebCore/platform/graphics/win/FontCacheWin.cpp:-398
> > -    return *simpleFont;
> 
> Oh no!

Thanks for reviewing, Brent!

[WebKit Commit Bot]

Comment on attachment 379748 [details]
Patch

Clearing flags on attachment: 379748

Committed r250459: <https://trac.webkit.org/changeset/250459>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.