Bug 202325 - [Win] Crash under FontCache::lastResortFallbackFont
Summary: [Win] Crash under FontCache::lastResortFallbackFont
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-27 11:26 PDT by Per Arne Vollan
Modified: 2019-09-27 14:05 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.65 KB, patch)
2019-09-27 11:34 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff
Patch (1.69 KB, patch)
2019-09-27 11:42 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2019-09-27 11:26:03 PDT
Backtrace:

 	WebKit.dll!WebCore::FontCache::lastResortFallbackFont(const WebCore::FontDescription & fontDescription) Line 393	C++	Symbols loaded.
	WebKit.dll!WebCore::FontCascadeFonts::realizeFallbackRangesAt(const WebCore::FontCascadeDescription & description, unsigned int index) Line 188	C++	Symbols loaded.
 	[Inline Frame] WebKit.dll!WebCore::FontCascadeFonts::primaryFont(const WebCore::FontCascadeDescription & description) Line 128	C++	Symbols loaded.
 	[Inline Frame] WebKit.dll!WebCore::FontCascade::primaryFont() Line 337	C++	Symbols loaded.
 	WebKit.dll!WebCore::StyleResolver::StyleResolver(WebCore::Document & document) Line 227	C++	Symbols loaded.
 	[Inline Frame] WebKit.dll!std::make_unique(WebCore::Document & <_Args_0>) Line 2539	C++	Symbols loaded.
 	WebKit.dll!WebCore::Style::Scope::resolver() Line 100	C++	Symbols loaded.
 	[Inline Frame] WebKit.dll!WebCore::Style::TreeResolver::Scope::{ctor}(WebCore::Document & document) Line 67	C++	Symbols loaded.
 	WebKit.dll!WebCore::Style::TreeResolver::resolve() Line 544	C++	Symbols loaded.
 	WebKit.dll!WebCore::Document::resolveStyle(WebCore::Document::ResolveStyleType type) Line 1938	C++	Symbols loaded.
 	WebKit.dll!WebCore::Document::updateStyleIfNeeded() Line 2082	C++	Symbols loaded.
 	WebKit.dll!WebCore::Document::finishedParsing() Line 5756	C++	Symbols loaded.
 	[Inline Frame] WebKit.dll!WebCore::HTMLDocumentParser::end() Line 427	C++	Symbols loaded.
 	[Inline Frame] WebKit.dll!WebCore::HTMLDocumentParser::attemptToRunDeferredScriptsAndEnd() Line 436	C++	Symbols loaded.
 	WebKit.dll!WebCore::HTMLDocumentParser::prepareToStopParsing() Line 142	C++	Symbols loaded.
 	[Inline Frame] WebKit.dll!WebCore::HTMLDocumentParser::attemptToEnd() Line 448	C++	Symbols loaded.
 	WebKit.dll!WebCore::HTMLDocumentParser::finish() Line 476	C++	Symbols loaded.
 	WebKit.dll!WebCore::DocumentWriter::end() Line 289	C++	Symbols loaded.
 	WebKit.dll!WebCore::DocumentLoader::finishedLoading() Line 446	C++	Symbols loaded.
 	WebKit.dll!WebCore::DocumentLoader::maybeLoadEmpty() Line 1715	C++	Symbols loaded.
 	WebKit.dll!WebCore::DocumentLoader::startLoadingMainResource() Line 1728	C++	Symbols loaded.
 	WebKit.dll!WebCore::FrameLoader::init() Line 315	C++	Symbols loaded.
 	WebKit.dll!WebView::initWithFrame(tagRECT frame, wchar_t * frameName, wchar_t * groupName) Line 3160	C++	Symbols loaded.
Comment 1 Per Arne Vollan 2019-09-27 11:34:25 PDT
Created attachment 379746 [details]
Patch
Comment 2 Per Arne Vollan 2019-09-27 11:40:49 PDT
<rdar://problem/47856730>
Comment 3 Per Arne Vollan 2019-09-27 11:42:51 PDT
Created attachment 379748 [details]
Patch
Comment 4 Brent Fulgham 2019-09-27 13:18:27 PDT
Comment on attachment 379748 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379748&action=review

Thank's for tracking this down.

> Source/WebCore/platform/graphics/win/FontCacheWin.cpp:-398
> -    return *simpleFont;

Oh no!
Comment 5 Per Arne Vollan 2019-09-27 13:21:31 PDT
(In reply to Brent Fulgham from comment #4)
> Comment on attachment 379748 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=379748&action=review
> 
> Thank's for tracking this down.
> 
> > Source/WebCore/platform/graphics/win/FontCacheWin.cpp:-398
> > -    return *simpleFont;
> 
> Oh no!

Thanks for reviewing, Brent!
Comment 6 WebKit Commit Bot 2019-09-27 14:05:11 PDT
Comment on attachment 379748 [details]
Patch

Clearing flags on attachment: 379748

Committed r250459: <https://trac.webkit.org/changeset/250459>
Comment 7 WebKit Commit Bot 2019-09-27 14:05:13 PDT
All reviewed patches have been landed.  Closing bug.