Bug 20231 - accNavigate: no screen element found in the specified direction should return S_FALSE
Summary: accNavigate: no screen element found in the specified direction should return...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P3 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-30 10:51 PDT by Jonas Klink
Modified: 2008-08-21 19:20 PDT (History)
1 user (show)

See Also:

Attachments
Fixes the issue described in this bug. (927 bytes, patch)
2008-07-30 16:02 PDT, Jonas Klink 		jhoneycutt: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonas Klink 2008-07-30 10:51:45 PDT 
In AccessibleBase::accNavigate, if childObj is null, we should return S_FALSE, not E_FAIL (see MSDN spec: http://msdn.microsoft.com/en-us/library/ms696145(VS.85).aspx).
Comment 1 Jonas Klink 2008-07-30 10:52:02 PDT 
jklink: have a patch for this ready
Comment 2 Jonas Klink 2008-07-30 16:02:51 PDT 
Created attachment 22567 [details]
Fixes the issue described in this bug.
Comment 3 Eric Seidel (no email) 2008-08-01 15:47:50 PDT 
Comment on attachment 22567 [details]
Fixes the issue described in this bug.

I assume Jon is the best person to review this.
Comment 4 Jon Honeycutt 2008-08-08 00:24:31 PDT 
Comment on attachment 22567 [details]
Fixes the issue described in this bug.

The ChangeLog should include the URL of the bug and of the MSDN page.

r=me, thanks, Jonas!
Comment 5 Mark Rowe (bdash) 2008-08-21 19:19:18 PDT 
Jonas, every patch of yours that I've tried to apply has given me "Malformed patch" errors in the ChangeLog hunk.  Can you please create patches using svn-create-patch in the future so that we don't have to jump through hoops and hand-edit your patches to apply them?  Thanks!
Comment 6 Mark Rowe (bdash) 2008-08-21 19:20:42 PDT 
Landed in r35887.