Bug 202297 - Add some logging to help diagnose blank or stuck WKWebViews
Summary: Add some logging to help diagnose blank or stuck WKWebViews
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-26 16:28 PDT by Tim Horton
Modified: 2019-09-26 17:59 PDT (History)
6 users (show)

See Also:

Attachments
Patch (18.73 KB, patch)
2019-09-26 16:34 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (18.76 KB, patch)
2019-09-26 17:14 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2019-09-26 16:28:37 PDT 
Add some logging to help diagnose blank or stuck WKWebViews
Comment 1 Tim Horton 2019-09-26 16:34:51 PDT 
Created attachment 379694 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2019-09-26 16:35:35 PDT 
<rdar://problem/55763610>
Comment 3 Wenson Hsieh 2019-09-26 17:07:13 PDT 
Comment on attachment 379694 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379694&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:379
> +    WTF::Optional<MonotonicTime> _timeOfFirstVisibleContentRectUpdateWithPendingCommit;

Nit - I don’t think the WTF:: is necessary here.
Comment 4 Tim Horton 2019-09-26 17:14:52 PDT 
Created attachment 379700 [details]
Patch
Comment 5 Tim Horton 2019-09-26 17:15:16 PDT 
You are correct though this file is full of it. I removed it in my case but not the others.
Comment 6 WebKit Commit Bot 2019-09-26 17:59:43 PDT 
Comment on attachment 379700 [details]
Patch

Clearing flags on attachment: 379700

Committed r250405: <https://trac.webkit.org/changeset/250405>
Comment 7 WebKit Commit Bot 2019-09-26 17:59:44 PDT 
All reviewed patches have been landed.  Closing bug.