Bug 202289 - Pages frequently fails to enter the back/forward cache due to pending loads
Summary: Pages frequently fails to enter the back/forward cache due to pending loads
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 202293
  Show dependency treegraph
 
Reported: 2019-09-26 14:26 PDT by Chris Dumez
Modified: 2019-09-26 23:17 PDT (History)
8 users (show)

See Also:


Attachments
Patch (17.62 KB, patch)
2019-09-26 14:38 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (17.34 KB, patch)
2019-09-26 14:41 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (17.29 KB, patch)
2019-09-26 15:16 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-09-26 14:26:15 PDT
Pages frequently fails to enter the back/forward cache due to pending loads. I think we should allow them to enter page cache as long as we've fired the load event in the main frame.
Comment 1 Radar WebKit Bug Importer 2019-09-26 14:26:32 PDT
<rdar://problem/55758506>
Comment 2 Chris Dumez 2019-09-26 14:38:29 PDT
Created attachment 379681 [details]
Patch
Comment 3 Chris Dumez 2019-09-26 14:41:40 PDT
Created attachment 379682 [details]
Patch
Comment 4 Chris Dumez 2019-09-26 15:16:06 PDT
Created attachment 379688 [details]
Patch
Comment 5 Geoffrey Garen 2019-09-26 22:09:17 PDT
Comment on attachment 379688 [details]
Patch

r=me
Comment 6 WebKit Commit Bot 2019-09-26 23:17:24 PDT
Comment on attachment 379688 [details]
Patch

Clearing flags on attachment: 379688

Committed r250414: <https://trac.webkit.org/changeset/250414>
Comment 7 WebKit Commit Bot 2019-09-26 23:17:26 PDT
All reviewed patches have been landed.  Closing bug.