Bug 202285 - Remove unused WebProcessPool::setCanHandleHTTPSServerTrustEvaluation
Summary: Remove unused WebProcessPool::setCanHandleHTTPSServerTrustEvaluation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-26 14:00 PDT by Alex Christensen
Modified: 2019-11-22 17:13 PST (History)
2 users (show)

See Also:

Attachments
Patch (31.96 KB, patch)
2019-09-26 14:06 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (29.62 KB, patch)
2019-09-26 14:59 PDT, Alex Christensen 		youennf: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2019-09-26 14:00:12 PDT 
Remove unused WebProcessPool::setCanHandleHTTPSServerTrustEvaluation
Comment 1 Alex Christensen 2019-09-26 14:06:24 PDT 
Created attachment 379678 [details]
Patch
Comment 2 Alex Christensen 2019-09-26 14:59:13 PDT 
Created attachment 379684 [details]
Patch
Comment 3 youenn fablet 2019-09-26 23:14:21 PDT 
Comment on attachment 379684 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379684&action=review

> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:580
> +            auto decisionHandler = makeBlockPtr([_session = makeWeakPtr(_session.get()), completionHandler = makeBlockPtr(completionHandler), taskIdentifier, networkDataTask = RefPtr<NetworkDataTaskCocoa>(networkDataTask)](NSURLAuthenticationChallenge *challenge, OSStatus trustResult) mutable {

makeRefPtr(networkDataTask)
Comment 4 Alex Christensen 2019-09-27 07:34:29 PDT 
http://trac.webkit.org/r250422
Comment 5 Radar WebKit Bug Importer 2019-09-27 07:35:18 PDT 
<rdar://problem/55781362>
Comment 6 Alex Christensen 2019-11-22 13:25:24 PST 
Reverted in http://trac.webkit.org/r252796
Needs more investigation.
Comment 7 Alex Christensen 2019-11-22 17:13:34 PST 
Relanded in http://trac.webkit.org/r252819