Bug 202272 – Support accessibility for <figure> element on iOS.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andres Gonzalez]

Support accessibility for <figure> element on iOS.

[Andres Gonzalez]

Created attachment 379648 [details]
Patch

[chris fleizach]

Comment on attachment 379648 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379648&action=review

> Source/WebCore/accessibility/AccessibilityObject.cpp:2618
> +        return AXFigureText();

It looks like we also have this line in the macOS wrapper

        case AccessibilityRole::Figure:
            return AXFigureText();

I think we can remove that since we're adding this into the lowest level of role description behavior

however. I think we still want people to be able to override figure text with their own aria_roledescription

maybe this would be better to put in the base accessibility wrapper and remove it from the Mac side...

[Andres Gonzalez]

Created attachment 379758 [details]
Patch

[Andres Gonzalez]

Fixed the aria-roledescription issue that you pointed out, updated the Mac wrapper and updated the roles-exposed test that was testing the figure element.

[chris fleizach]

Comment on attachment 379758 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379758&action=review

> LayoutTests/accessibility/ios-simulator/figure-element.html:33
> +<figure id="figure5" title="Figure 5.">

can you add one more case for a figure that overrides with aria-roledescription ?

[Andres Gonzalez]

Created attachment 379768 [details]
Patch

[Andres Gonzalez]

figure 4 has aria-roledescription attribute.

[WebKit Commit Bot]

Comment on attachment 379768 [details]
Patch

Clearing flags on attachment: 379768

Committed r250462: <https://trac.webkit.org/changeset/250462>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/55796504>

[Truitt Savell]

It looks like this change https://trac.webkit.org/changeset/250462/webkit

broke accessibility/roles-exposed.html

History:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=accessibility%2Froles-exposed.html

Diff:
--- /Volumes/Data/slave/highsierra-release-tests-wk1/build/layout-test-results/accessibility/roles-exposed-expected.txt
+++ /Volumes/Data/slave/highsierra-release-tests-wk1/build/layout-test-results/accessibility/roles-exposed-actual.txt
@@ -129,6 +129,11 @@
       AXSubrole: 
       AXRoleDescription: 
       
+figure
+      AXRole: AXGroup
+      AXSubrole: 
+      AXRoleDescription: figure
+      
 footer
       AXRole: AXGroup
       AXSubrole: AXLandmarkContentInfo

I was able to reproduce this locally. Is this expected behavior and need a rebasline?

[chris fleizach]

(In reply to Truitt Savell from comment #11)
> It looks like this change https://trac.webkit.org/changeset/250462/webkit
> 
> broke accessibility/roles-exposed.html
> 
> History:
> https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.
> html#showAllRuns=true&tests=accessibility%2Froles-exposed.html
> 
> Diff:
> ---
> /Volumes/Data/slave/highsierra-release-tests-wk1/build/layout-test-results/
> accessibility/roles-exposed-expected.txt
> +++
> /Volumes/Data/slave/highsierra-release-tests-wk1/build/layout-test-results/
> accessibility/roles-exposed-actual.txt
> @@ -129,6 +129,11 @@
>        AXSubrole: 
>        AXRoleDescription: 
>        
> +figure
> +      AXRole: AXGroup
> +      AXSubrole: 
> +      AXRoleDescription: figure
> +      
>  footer
>        AXRole: AXGroup
>        AXSubrole: AXLandmarkContentInfo
> 
> I was able to reproduce this locally. Is this expected behavior and need a
> rebasline?

Yes, just need a WK1 rebase line

[Aakash Jain]

> Yes, just need a WK1 rebase line
Can we rebaseline quickly. This is slowing down EWS.

[Andres Gonzalez]

Reopening to attach new patch.

[Andres Gonzalez]

Created attachment 379907 [details]
Patch

[Andres Gonzalez]

Latest patch fixes WK1 test. Sorry about this oversight.

[Aakash Jain]

Comment on attachment 379907 [details]
Patch

r=me if it passes EWS.

[Alexey Proskuryakov]

*** Bug 202404 has been marked as a duplicate of this bug. ***

[WebKit Commit Bot]

Comment on attachment 379907 [details]
Patch

Clearing flags on attachment: 379907

Committed r250564: <https://trac.webkit.org/changeset/250564>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.