Bug 202262 - [Cocoa] REGRESSION (r245672): Contenteditable with optical sizing freezes Safari
Summary: [Cocoa] REGRESSION (r245672): Contenteditable with optical sizing freezes Safari
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: Other
Hardware: Mac macOS 10.14
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
: 202556 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-09-26 02:40 PDT by nilfgard
Modified: 2019-10-14 12:43 PDT (History)
11 users (show)

See Also:


Attachments
Patch (18.90 KB, patch)
2019-10-03 18:32 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (16.17 KB, patch)
2019-10-04 14:12 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (16.65 KB, patch)
2019-10-04 15:03 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (26.40 KB, patch)
2019-10-10 19:01 PDT, Myles C. Maxfield
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description nilfgard 2019-09-26 02:40:58 PDT
Hello.

Contenteditable + text-rendering: optimizeLegibility + font-family: -apple-system crashes Safari 13 and 13.0.1.

This codepen shows the problem: https://codepen.io/nilfgard/pen/GRKLgqr
Comment 1 Alexey Proskuryakov 2019-09-29 15:22:05 PDT

*** This bug has been marked as a duplicate of bug 202198 ***
Comment 2 Myles C. Maxfield 2019-10-03 17:37:02 PDT
The fix for the other bug doesn't fix this one.
Comment 3 Myles C. Maxfield 2019-10-03 18:31:23 PDT
*** Bug 202556 has been marked as a duplicate of this bug. ***
Comment 4 Myles C. Maxfield 2019-10-03 18:32:43 PDT
Created attachment 380179 [details]
Patch
Comment 5 Radar WebKit Bug Importer 2019-10-03 18:33:08 PDT
<rdar://problem/55969922>
Comment 6 Alexey Proskuryakov 2019-10-03 19:37:24 PDT
There is some build breakage on EWS.
Comment 7 Myles C. Maxfield 2019-10-04 14:10:09 PDT
*** Bug 202556 has been marked as a duplicate of this bug. ***
Comment 8 Myles C. Maxfield 2019-10-04 14:12:32 PDT
Created attachment 380252 [details]
Patch
Comment 9 Myles C. Maxfield 2019-10-04 15:03:06 PDT
Created attachment 380256 [details]
Patch
Comment 10 Alexey Proskuryakov 2019-10-04 18:24:28 PDT
fast/forms/contenteditable-font-optical-size.html is failing on iOS.
Comment 11 Myles C. Maxfield 2019-10-10 19:01:24 PDT
Created attachment 380713 [details]
Patch
Comment 12 Tim Horton 2019-10-14 10:24:54 PDT
Comment on attachment 380713 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380713&action=review

> Source/WebKit/Shared/Cocoa/CoreTextHelpers.mm:2
> + * Copyright (C) 2017 Apple Inc. All rights reserved.

-2019?

> Source/WebKit/Shared/Cocoa/CoreTextHelpers.mm:52
> +    END_BLOCK_OBJC_EXCEPTIONS

I *think* this being post-return is OK, but I don't recall what it expands to
Comment 13 Myles C. Maxfield 2019-10-14 12:43:09 PDT
Committed r251086: <https://trac.webkit.org/changeset/251086>