RESOLVED FIXED 202257
We need to initialize the Gigacage first in setJITEnabled() when disabling the JIT. 
https://bugs.webkit.org/show_bug.cgi?id=202257
Summary We need to initialize the Gigacage first in setJITEnabled() when disabling th...
Mark Lam
Reported 2019-09-25 23:14:58 PDT
Details to follow in the ChangeLog.
Attachments
proposed patch. (2.53 KB, patch)
2019-09-26 00:27 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
proposed patch. (2.53 KB, patch)
2019-09-26 00:30 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2019-09-26 00:27:44 PDT
Created attachment 379621 [details] proposed patch.
Mark Lam
Comment 2 2019-09-26 00:28:36 PDT
<rdar://problem/55673084>
Mark Lam
Comment 3 2019-09-26 00:30:29 PDT
Created attachment 379622 [details] proposed patch.
Saam Barati
Comment 4 2019-09-26 07:00:25 PDT
Comment on attachment 379622 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=379622&action=review > Source/JavaScriptCore/jit/ExecutableAllocator.cpp:132 > if (!enabled) { Why do we do the JIT allocation when !enabled? Seems backwards, right?
WebKit Commit Bot
Comment 5 2019-09-26 08:07:23 PDT
Comment on attachment 379622 [details] proposed patch. Clearing flags on attachment: 379622 Committed r250383: <https://trac.webkit.org/changeset/250383>
WebKit Commit Bot
Comment 6 2019-09-26 08:07:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.