Bug 202254 - [iOS 13] Tapping on a non-editable text selection should toggle callout bar visibility instead of clearing selection
Summary: [iOS 13] Tapping on a non-editable text selection should toggle callout bar v...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-25 20:58 PDT by Wenson Hsieh
Modified: 2019-09-26 12:11 PDT (History)
7 users (show)

See Also:


Attachments
Patch (14.55 KB, patch)
2019-09-26 09:19 PDT, Wenson Hsieh
megan_gardner: review+
Details | Formatted Diff | Diff
Patch for landing (14.55 KB, patch)
2019-09-26 10:58 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2019-09-25 20:58:09 PDT
<rdar://problem/54410263>
Comment 1 Wenson Hsieh 2019-09-26 09:19:49 PDT
Created attachment 379645 [details]
Patch
Comment 2 Megan Gardner 2019-09-26 10:47:47 PDT
Comment on attachment 379645 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379645&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2191
> +

I’m guessing that the unobscuredArea check is for not doing a divide by zero, but if there is no unobscured area, should we be toggling or clearing? Clearing might make sense on this case as well?
Comment 3 Wenson Hsieh 2019-09-26 10:55:14 PDT
Comment on attachment 379645 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379645&action=review

Thanks for the review!

>> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2191
>> +
> 
> I’m guessing that the unobscuredArea check is for not doing a divide by zero, but if there is no unobscured area, should we be toggling or clearing? Clearing might make sense on this case as well?

Good call — changed this check to `!unobscuredArea || …`.
Comment 4 Wenson Hsieh 2019-09-26 10:58:50 PDT
Created attachment 379660 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2019-09-26 12:03:54 PDT
Comment on attachment 379660 [details]
Patch for landing

Clearing flags on attachment: 379660

Committed r250392: <https://trac.webkit.org/changeset/250392>