RESOLVED FIXED 202254
[iOS 13] Tapping on a non-editable text selection should toggle callout bar visibility instead of clearing selection 
https://bugs.webkit.org/show_bug.cgi?id=202254
Summary [iOS 13] Tapping on a non-editable text selection should toggle callout bar v...
Wenson Hsieh
Reported 2019-09-25 20:58:09 PDT
<rdar://problem/54410263>
Attachments
Patch (14.55 KB, patch)
2019-09-26 09:19 PDT, Wenson Hsieh 		megan_gardner: review+
DetailsFormatted DiffDiff
Patch for landing (14.55 KB, patch)
2019-09-26 10:58 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2019-09-26 09:19:49 PDT
Created attachment 379645 [details] Patch
Megan Gardner
Comment 2 2019-09-26 10:47:47 PDT
Comment on attachment 379645 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379645&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2191 > + I’m guessing that the unobscuredArea check is for not doing a divide by zero, but if there is no unobscured area, should we be toggling or clearing? Clearing might make sense on this case as well?
Wenson Hsieh
Comment 3 2019-09-26 10:55:14 PDT
Comment on attachment 379645 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379645&action=review Thanks for the review! >> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2191 >> + > > I’m guessing that the unobscuredArea check is for not doing a divide by zero, but if there is no unobscured area, should we be toggling or clearing? Clearing might make sense on this case as well? Good call — changed this check to `!unobscuredArea || …`.
Wenson Hsieh
Comment 4 2019-09-26 10:58:50 PDT
Created attachment 379660 [details] Patch for landing
WebKit Commit Bot
Comment 5 2019-09-26 12:03:54 PDT
Comment on attachment 379660 [details] Patch for landing Clearing flags on attachment: 379660 Committed r250392: <https://trac.webkit.org/changeset/250392>
Note You need to log in before you can comment on or make changes to this bug.