Bug 20224 - Include the Writing Direction sub-menu in the context menu of the Qt port.
: Include the Writing Direction sub-menu in the context menu of the Qt port.
Status: RESOLVED FIXED
: WebKit
WebKit Qt
: 528+ (Nightly build)
: All Mac OS X 10.5
: P2 Enhancement
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2008-07-29 22:09 PST by
Modified: 2008-07-31 10:20 PST (History)


Attachments
Implements inclusion of the Writing Direction sub-menu. (1.56 KB, patch)
2008-07-29 22:11 PST, Erik L. Bunce
hausmann: review-
Review Patch | Details | Formatted Diff | Diff
Implements inclusion of the writing Direction sub-menu on all non-GTK platforms. (1.59 KB, patch)
2008-07-31 08:15 PST, Erik L. Bunce
hausmann: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2008-07-29 22:09:03 PST
Include the Writing Direction sub-menu in the context menu of the Qt port.
This can be helpful in international contexts, also makes us more on par with the Mac port.
------- Comment #1 From 2008-07-29 22:11:50 PST -------
Created an attachment (id=22550) [details]
Implements inclusion of the Writing Direction sub-menu.

Part of the great bug 20207 patch split...
------- Comment #2 From 2008-07-31 06:14:07 PST -------
(From update of attachment 22550 [details])
I agree with the patch in principle, but I think the #ifdefs are not entirely correct. Revision 34426 accidentially put the writing direction menu item into a PLATFORM(MAC) block where previously it was effectively !PLATFORM(GTK). Before the  change it was available on all platforms (mac, win, wx, qt, etc.) except Gtk, now it's only available for the mac. Can you fix it that way around using !PLATFORM(GTK) and refer to change 34426 in the change log?

Thanks :)
------- Comment #3 From 2008-07-31 08:15:41 PST -------
Created an attachment (id=22576) [details]
Implements inclusion of the writing Direction sub-menu on all non-GTK platforms.
------- Comment #4 From 2008-07-31 10:19:25 PST -------
(From update of attachment 22576 [details])
Thanks!
------- Comment #5 From 2008-07-31 10:20:13 PST -------
Landed in r35486