Bug 202229 – [GTK] CSS dark mode tests show spurious numbers

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Alicia Boya García]

css-dark-mode/color-scheme-css.html
css-dark-mode/color-scheme-meta.html
css-dark-mode/older-syntax/supported-color-schemes-css.html
css-dark-mode/older-syntax/supported-color-schemes-meta.html

Failing since r249883:r249933

--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/css-dark-mode/color-scheme-meta-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/css-dark-mode/color-scheme-meta-actual.txt
@@ -5,15 +5,15 @@
 PASS Light color scheme enabled 
 PASS Color schemes changed to light and dark 
 PASS Element colors are correct in light color scheme with light and dark color scheme 
-PASS Dark color scheme enabled 
+PASS Dark color scheme enabled 2 
 PASS Element colors are correct in dark color scheme with light and dark color scheme 
-PASS Light color scheme enabled 
+PASS Light color scheme enabled 2 
 PASS Color schemes changed to dark 
 FAIL Element colors are correct in light color scheme with only dark color scheme assert_equals: expected "rgb(255, 255, 255)" but got "rgb(0, 0, 0)"
-PASS Dark color scheme enabled 
+PASS Dark color scheme enabled 3 
 PASS Element colors are correct in dark color scheme with only dark color scheme 
 PASS Color schemes changed to light and a bogus value 
-FAIL Element colors are correct in dark color scheme with only light color scheme assert_equals: expected "rgb(0, 0, 0)" but got "rgb(255, 255, 255)"
+FAIL Element colors are correct in dark color scheme with only light color scheme 2 assert_equals: expected "rgb(0, 0, 0)" but got "rgb(255, 255, 255)"
 PASS Color schemes changed to empty value 
 FAIL Element colors are correct in dark color scheme with implicit light color scheme assert_equals: expected "rgb(0, 0, 0)" but got "rgb(255, 255, 255)"
 PASS Color schemes changed to light,dark

[Carlos Alberto Lopez Perez]

This test is crashing sometimes randomly. On the last 4000 runs it has crashed 26 times. The crash log points to something related with the graphics drivers.

Thread 1 (Thread 0x7fa7459ff700 (LWP 1814)):
#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
#1  0x00007fa7a09c4855 in __GI_abort () at abort.c:79
#2  0x00007fa7a09c4729 in __assert_fail_base (fmt=0x7fa7a0b320e8 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", assertion=0x7fa737695c10 "c != _SIMPLE_MTX_INVALID_VALUE", file=0x7fa737695caf "../src/util/simple_mtx.h", line=89, function=<optimized out>) at assert.c:92
#3  0x00007fa7a09d3db6 in __GI___assert_fail (assertion=assertion@entry=0x7fa737695c10 "c != _SIMPLE_MTX_INVALID_VALUE", file=file@entry=0x7fa737695caf "../src/util/simple_mtx.h", line=line@entry=89, function=function@entry=0x7fa7376a2e90 <__PRETTY_FUNCTION__.11> "simple_mtx_lock") at assert.c:101
#4  0x00007fa736874a35 in simple_mtx_lock (mtx=0x7fa6840eb910) at ../src/util/simple_mtx.h:83
#5  0x00007fa7368752fe in simple_mtx_lock (mtx=0x7fa6840eb910) at ../src/util/simple_mtx.h:94
#6  st_save_zombie_sampler_view (st=0x7fa6840ea0a0, view=<optimized out>) at ../src/mesa/state_tracker/st_context.c:315
#7  0x00007fa7368670bd in st_texture_release_all_sampler_views (st=st@entry=0x7fa730349c40, stObj=stObj@entry=0x7fa68433dd40) at ../src/mesa/state_tracker/st_sampler_view.c:233
#8  0x00007fa7368677bf in st_texture_release_all_sampler_views (stObj=0x7fa68433dd40, st=0x7fa730349c40) at ../src/mesa/state_tracker/st_sampler_view.c:221
#9  st_delete_texture_sampler_views (st=st@entry=0x7fa730349c40, stObj=stObj@entry=0x7fa68433dd40) at ../src/mesa/state_tracker/st_sampler_view.c:253
#10 0x00007fa7368566be in st_DeleteTextureObject (ctx=0x7fa7304b5560, texObj=0x7fa68433dd40) at ../src/mesa/state_tracker/st_cb_texture.c:193
#11 0x00007fa736a1d670 in _mesa_reference_texobj_ (ptr=ptr@entry=0x7fa7304c8c28, tex=tex@entry=0x7fa730ade450) at ../src/mesa/main/texobj.c:607
#12 0x00007fa736a1d9f8 in _mesa_reference_texobj (tex=0x7fa730ade450, ptr=0x7fa7304c8c28) at ../src/mesa/main/texobj.h:100
#13 bind_texture_object (ctx=0x7fa7304b5560, unit=2, texObj=0x7fa730ade450) at ../src/mesa/main/texobj.c:1691
#14 0x00007fa7aad160e6 in WebCore::BitmapTextureGL::updateContents(void const*, WebCore::IntRect const&, WebCore::IntPoint const&, int) () at /app/webkit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
#15 0x00007fa7a93b67bc in WebCore::CoordinatedBackingStoreTile::swapBuffers(WebCore::TextureMapper&) () at /app/webkit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
#16 0x00007fa7a93b7875 in WebCore::CoordinatedBackingStore::commitTileOperations(WebCore::TextureMapper&) () at /app/webkit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
#17 0x00007fa7a8ebaea6 in WebKit::CoordinatedGraphicsScene::updateSceneState() () at /app/webkit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
#18 0x00007fa7a8eb9662 in WebKit::CoordinatedGraphicsScene::paintToCurrentGLContext(WebCore::TransformationMatrix const&, WebCore::FloatRect const&, unsigned int) () at /app/webkit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
#19 0x00007fa7a8ebd32b in WebKit::ThreadedCompositor::renderLayerTree() () at /app/webkit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
#20 0x00007fa7a6459dac in WTF::RunLoop::TimerBase::TimerBase(WTF::RunLoop&)::$_3::__invoke(void*) () at /app/webkit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18
#21 0x00007fa7a645920a in WTF::RunLoop::$_0::__invoke(_GSource*, int (*)(void*), void*) () at /app/webkit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18
#22 0x00007fa7a1e6704f in g_main_dispatch (context=0x7fa730000b60) at ../glib/gmain.c:3325
#23 g_main_context_dispatch (context=0x7fa730000b60) at ../glib/gmain.c:4016
#24 0x00007fa7a1e673f8 in g_main_context_iterate (context=0x7fa730000b60, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at ../glib/gmain.c:4092
#25 0x00007fa7a1e67713 in g_main_loop_run (loop=0x7fa730001480) at ../glib/gmain.c:4290
#26 0x00007fa7a64597ab in WTF::RunLoop::run() () at /app/webkit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18
#27 0x00007fa7a64009a0 in WTF::Thread::entryPoint(WTF::Thread::NewThreadContext*) () at /app/webkit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18
#28 0x00007fa7a645bf46 in WTF::wtfThreadEntryPoint(void*) () at /app/webkit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18
#29 0x00007fa7a2f5b4d2 in start_thread (arg=<optimized out>) at pthread_create.c:477
#30 0x00007fa7a0aa04d3 in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

https://build.webkit.org/results/GTK-Linux-64-bit-Release-Tests/r268900%20(16593)/css-dark-mode/older-syntax/supported-color-schemes-css-crash-log.txt

[Diego Pino]

(In reply to Carlos Alberto Lopez Perez from comment #1)
> This test is crashing sometimes randomly. On the last 4000 runs it has
> crashed 26 times. The crash log points to something related with the
> graphics drivers.
> 
> Thread 1 (Thread 0x7fa7459ff700 (LWP 1814)):
> #0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
> #1  0x00007fa7a09c4855 in __GI_abort () at abort.c:79
> #2  0x00007fa7a09c4729 in __assert_fail_base (fmt=0x7fa7a0b320e8 "%s%s%s:%u:
> %s%sAssertion `%s' failed.\n%n", assertion=0x7fa737695c10 "c !=
> _SIMPLE_MTX_INVALID_VALUE", file=0x7fa737695caf "../src/util/simple_mtx.h",
> line=89, function=<optimized out>) at assert.c:92
> #3  0x00007fa7a09d3db6 in __GI___assert_fail
> (assertion=assertion@entry=0x7fa737695c10 "c != _SIMPLE_MTX_INVALID_VALUE",
> file=file@entry=0x7fa737695caf "../src/util/simple_mtx.h",
> line=line@entry=89, function=function@entry=0x7fa7376a2e90
> <__PRETTY_FUNCTION__.11> "simple_mtx_lock") at assert.c:101
> #4  0x00007fa736874a35 in simple_mtx_lock (mtx=0x7fa6840eb910) at
> ../src/util/simple_mtx.h:83
> #5  0x00007fa7368752fe in simple_mtx_lock (mtx=0x7fa6840eb910) at
> ../src/util/simple_mtx.h:94
> #6  st_save_zombie_sampler_view (st=0x7fa6840ea0a0, view=<optimized out>) at
> ../src/mesa/state_tracker/st_context.c:315
> #7  0x00007fa7368670bd in st_texture_release_all_sampler_views
> (st=st@entry=0x7fa730349c40, stObj=stObj@entry=0x7fa68433dd40) at
> ../src/mesa/state_tracker/st_sampler_view.c:233
> #8  0x00007fa7368677bf in st_texture_release_all_sampler_views
> (stObj=0x7fa68433dd40, st=0x7fa730349c40) at
> ../src/mesa/state_tracker/st_sampler_view.c:221
> #9  st_delete_texture_sampler_views (st=st@entry=0x7fa730349c40,
> stObj=stObj@entry=0x7fa68433dd40) at
> ../src/mesa/state_tracker/st_sampler_view.c:253
> #10 0x00007fa7368566be in st_DeleteTextureObject (ctx=0x7fa7304b5560,
> texObj=0x7fa68433dd40) at ../src/mesa/state_tracker/st_cb_texture.c:193
> #11 0x00007fa736a1d670 in _mesa_reference_texobj_
> (ptr=ptr@entry=0x7fa7304c8c28, tex=tex@entry=0x7fa730ade450) at
> ../src/mesa/main/texobj.c:607
> #12 0x00007fa736a1d9f8 in _mesa_reference_texobj (tex=0x7fa730ade450,
> ptr=0x7fa7304c8c28) at ../src/mesa/main/texobj.h:100
> #13 bind_texture_object (ctx=0x7fa7304b5560, unit=2, texObj=0x7fa730ade450)
> at ../src/mesa/main/texobj.c:1691
> #14 0x00007fa7aad160e6 in WebCore::BitmapTextureGL::updateContents(void
> const*, WebCore::IntRect const&, WebCore::IntPoint const&, int) () at
> /app/webkit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
> #15 0x00007fa7a93b67bc in
> WebCore::CoordinatedBackingStoreTile::swapBuffers(WebCore::TextureMapper&)
> () at /app/webkit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
> #16 0x00007fa7a93b7875 in
> WebCore::CoordinatedBackingStore::commitTileOperations(WebCore::
> TextureMapper&) () at
> /app/webkit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
> #17 0x00007fa7a8ebaea6 in
> WebKit::CoordinatedGraphicsScene::updateSceneState() () at
> /app/webkit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
> #18 0x00007fa7a8eb9662 in
> WebKit::CoordinatedGraphicsScene::paintToCurrentGLContext(WebCore::
> TransformationMatrix const&, WebCore::FloatRect const&, unsigned int) () at
> /app/webkit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
> #19 0x00007fa7a8ebd32b in WebKit::ThreadedCompositor::renderLayerTree() ()
> at /app/webkit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37
> #20 0x00007fa7a6459dac in
> WTF::RunLoop::TimerBase::TimerBase(WTF::RunLoop&)::$_3::__invoke(void*) ()
> at /app/webkit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18
> #21 0x00007fa7a645920a in WTF::RunLoop::$_0::__invoke(_GSource*, int
> (*)(void*), void*) () at
> /app/webkit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18
> #22 0x00007fa7a1e6704f in g_main_dispatch (context=0x7fa730000b60) at
> ../glib/gmain.c:3325
> #23 g_main_context_dispatch (context=0x7fa730000b60) at ../glib/gmain.c:4016
> #24 0x00007fa7a1e673f8 in g_main_context_iterate (context=0x7fa730000b60,
> block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at
> ../glib/gmain.c:4092
> #25 0x00007fa7a1e67713 in g_main_loop_run (loop=0x7fa730001480) at
> ../glib/gmain.c:4290
> #26 0x00007fa7a64597ab in WTF::RunLoop::run() () at
> /app/webkit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18
> #27 0x00007fa7a64009a0 in
> WTF::Thread::entryPoint(WTF::Thread::NewThreadContext*) () at
> /app/webkit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18
> #28 0x00007fa7a645bf46 in WTF::wtfThreadEntryPoint(void*) () at
> /app/webkit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18
> #29 0x00007fa7a2f5b4d2 in start_thread (arg=<optimized out>) at
> pthread_create.c:477
> #30 0x00007fa7a0aa04d3 in clone () at
> ../sysdeps/unix/sysv/linux/x86_64/clone.S:95
> 
> https://build.webkit.org/results/GTK-Linux-64-bit-Release-Tests/
> r268900%20(16593)/css-dark-mode/older-syntax/supported-color-schemes-css-
> crash-log.txt

Crashes with a stacktrace like this started happening after the Flatpak SDK 0.3 upgrade. We're tracking down crashes with this error ("c != _SIMPLE_MTX_INVALID_VALUE") under bug https://bugs.webkit.org/show_bug.cgi?id=216777.

The error seems to be due to a regression in Mesa (https://gitlab.freedesktop.org/mesa/mesa/blob/master/docs/relnotes/20.1.8.rst). The current Flatpak SDK uses Mesa 20.1.5 (https://github.com/WebKit/webkit/blob/master/Tools/buildstream/elements/sdk/mesa.bst), although it cherry-picks the patch that in theory fixes this regression (https://github.com/WebKit/webkit/blob/master/Tools/buildstream/patches/mesa/0003-mesa-st-release-debug_output-after-destroying-the-co.patch). However, the issue is still happening.

[Diego Pino]

This test(s) has been passing constantly for the last 4000 revisions. Test expectations updated in r287508. There are no more test failures filed under this bug. Closing bug.