Bug 202222 - Don't fall back to default session if session can't be found for cookie operations
Summary: Don't fall back to default session if session can't be found for cookie opera...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-25 12:35 PDT by Alex Christensen
Modified: 2019-09-25 12:44 PDT (History)
2 users (show)

See Also:

Attachments
Patch (8.76 KB, patch)
2019-09-25 12:37 PDT, Alex Christensen 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2019-09-25 12:35:25 PDT 
Don't fall back to default session if session can't be found for cookie operations
Comment 1 Alex Christensen 2019-09-25 12:37:31 PDT 
Created attachment 379573 [details]
Patch
Comment 2 Geoffrey Garen 2019-09-25 12:40:43 PDT 
Comment on attachment 379573 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379573&action=review

r=me

> Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:-505
> -        LOG_ERROR("Non-default storage session was requested, but there was no session for it. Please file a bug unless you just disabled private browsing, in which case it's an expected race.");

Should we leave behind this LOG_ERROR? Seems like a real error.
Comment 3 Alex Christensen 2019-09-25 12:43:19 PDT 
I left it. http://trac.webkit.org/r250354
Comment 4 Radar WebKit Bug Importer 2019-09-25 12:44:18 PDT 
<rdar://problem/55714819>