RESOLVED FIXED 202216
[EWS] RunJavaScriptCoreTestsToT should use the same command as RunJavaScriptCoreTests 
https://bugs.webkit.org/show_bug.cgi?id=202216
Summary [EWS] RunJavaScriptCoreTestsToT should use the same command as RunJavaScriptC...
Aakash Jain
Reported 2019-09-25 11:42:03 PDT
RunJavaScriptCoreTestsToT should use the same command as base class RunJavaScriptCoreTests. Currently the difference between the command in both classes is that RunJavaScriptCoreTestsToT doesn't add '--no-build'. This was correct prior to Bug 202170 when there wasn't an explicit CompileJSC step before RunJavaScriptCoreTestsToT. In Bug 202170, we added an explicit build step CompileJSCToT() which is run before RunJavaScriptCoreTestsToT(). Therefore we can add the '--no-build' flag here and make it same as the base class (RunJavaScriptCoreTests).
Attachments
Patch (3.02 KB, patch)
2019-09-25 11:46 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-09-25 11:46:45 PDT
Created attachment 379569 [details] Patch
WebKit Commit Bot
Comment 2 2019-09-25 14:12:10 PDT
Comment on attachment 379569 [details] Patch Clearing flags on attachment: 379569 Committed r250357: <https://trac.webkit.org/changeset/250357>
WebKit Commit Bot
Comment 3 2019-09-25 14:12:12 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2019-09-25 14:13:17 PDT
<rdar://problem/55718281>
Note You need to log in before you can comment on or make changes to this bug.