Bug 202216 - [EWS] RunJavaScriptCoreTestsToT should use the same command as RunJavaScriptCoreTests
Summary: [EWS] RunJavaScriptCoreTestsToT should use the same command as RunJavaScriptC...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-25 11:42 PDT by Aakash Jain
Modified: 2019-09-25 14:13 PDT (History)
5 users (show)

See Also:


Attachments
Patch (3.02 KB, patch)
2019-09-25 11:46 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-09-25 11:42:03 PDT
RunJavaScriptCoreTestsToT should use the same command as base class RunJavaScriptCoreTests. Currently the difference between the command in both classes is that RunJavaScriptCoreTestsToT doesn't add '--no-build'. This was correct prior to Bug 202170 when there wasn't an explicit CompileJSC step before RunJavaScriptCoreTestsToT. In Bug 202170, we added an explicit build step CompileJSCToT() which is run before RunJavaScriptCoreTestsToT(). Therefore we can add the '--no-build' flag here and make it same as the base class (RunJavaScriptCoreTests).
Comment 1 Aakash Jain 2019-09-25 11:46:45 PDT
Created attachment 379569 [details]
Patch
Comment 2 WebKit Commit Bot 2019-09-25 14:12:10 PDT
Comment on attachment 379569 [details]
Patch

Clearing flags on attachment: 379569

Committed r250357: <https://trac.webkit.org/changeset/250357>
Comment 3 WebKit Commit Bot 2019-09-25 14:12:12 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2019-09-25 14:13:17 PDT
<rdar://problem/55718281>