Bug 20221 - [Qt] ToggleBold, ToggleItalic, and ToggleUnderline page actions should update during navigation.
Summary: [Qt] ToggleBold, ToggleItalic, and ToggleUnderline page actions should update...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-29 21:08 PDT by Erik L. Bunce
Modified: 2008-08-04 09:02 PDT (History)
0 users

See Also:


Attachments
Adds support for updating more editing related actions. (9.37 KB, patch)
2008-07-29 21:10 PDT, Erik L. Bunce
hausmann: review-
Details | Formatted Diff | Diff
Adds support for updating more editing related actions. (9.27 KB, patch)
2008-08-04 08:22 PDT, Erik L. Bunce
hausmann: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Erik L. Bunce 2008-07-29 21:08:15 PDT
Currently when editing a page the ToggleBold, ToggleItalic, and ToggleUnderline page actions don't update as you navigation the page being edited.  Can be demonstrated with the QtLauncher included in the patch attached to bug 20220.
Comment 1 Erik L. Bunce 2008-07-29 21:10:41 PDT
Created attachment 22547 [details]
Adds support for updating more editing related actions.

Add updateAction() support to ToggleBold, ToggleItalic, and ToggleUnderline.
Add lookup table for mapping web actions to editor commands.
Comment 2 Erik L. Bunce 2008-07-29 21:24:35 PDT
Comment on attachment 22547 [details]
Adds support for updating more editing related actions.

Part of the great bug 20207 patch split.
Comment 3 Simon Hausmann 2008-08-04 02:50:08 PDT
Comment on attachment 22547 [details]
Adds support for updating more editing related actions.

I agree with the patch in principle (thanks!), but there are a few minor cosmetic glitches:

1) Please make the editorCommandWebActions array local to qwebpage.cpp by prepending 'static'.

2) You commented out the cases for all the editor actions and handle it in default: instead. That's fine, but I don't think we should leave the old code commented out, please just remove it :)

3) The last item in the array should probably not end with a comma :)

r- because of those, but I'd be happy to r+ with them fixed.
Comment 4 Erik L. Bunce 2008-08-04 08:22:25 PDT
Created attachment 22633 [details]
Adds support for updating more editing related actions.

Updated based on Simon Hausmann's comments.
Comment 5 Simon Hausmann 2008-08-04 09:02:39 PDT
Landed in r35537