Bug 20221 – [Qt] ToggleBold, ToggleItalic, and ToggleUnderline page actions should update during navigation.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Erik L. Bunce]

Currently when editing a page the ToggleBold, ToggleItalic, and ToggleUnderline page actions don't update as you navigation the page being edited.  Can be demonstrated with the QtLauncher included in the patch attached to bug 20220.

[Erik L. Bunce]

Created attachment 22547 [details]
Adds support for updating more editing related actions.

Add updateAction() support to ToggleBold, ToggleItalic, and ToggleUnderline.
Add lookup table for mapping web actions to editor commands.

[Erik L. Bunce]

Comment on attachment 22547 [details]
Adds support for updating more editing related actions.

Part of the great bug 20207 patch split.

[Simon Hausmann]

Comment on attachment 22547 [details]
Adds support for updating more editing related actions.

I agree with the patch in principle (thanks!), but there are a few minor cosmetic glitches:

1) Please make the editorCommandWebActions array local to qwebpage.cpp by prepending 'static'.

2) You commented out the cases for all the editor actions and handle it in default: instead. That's fine, but I don't think we should leave the old code commented out, please just remove it :)

3) The last item in the array should probably not end with a comma :)

r- because of those, but I'd be happy to r+ with them fixed.

[Erik L. Bunce]

Created attachment 22633 [details]
Adds support for updating more editing related actions.

Updated based on Simon Hausmann's comments.

[Simon Hausmann]

Landed in r35537