RESOLVED FIXED 202201
[Nicosia] Implement frame scrolling functionality 
https://bugs.webkit.org/show_bug.cgi?id=202201
Summary [Nicosia] Implement frame scrolling functionality
Zan Dobersek
Reported 2019-09-25 06:32:54 PDT
[Nicosia] Implement frame scrolling functionality
Attachments
Patch (12.24 KB, patch)
2019-09-25 06:47 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2019-09-25 06:47:07 PDT
Created attachment 379545 [details] Patch
Carlos Garcia Campos
Comment 2 2019-09-27 01:29:19 PDT
Comment on attachment 379545 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379545&action=review > Source/WebCore/page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.cpp:161 > + [&position](Nicosia::CompositionLayer::LayerState& state) why not position = WTFMove(position)? it's an rvalue ref > Source/WebCore/page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.cpp:163 > + state.position = position; and WTFMove(position) here too. > Source/WebCore/page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.cpp:183 > + applyLayerPosition(*m_rootContentsLayer, rootContentsPosition); > + if (m_contentShadowLayer) > + applyLayerPosition(*m_contentShadowLayer, rootContentsPosition); hmm position can't be moved, so maybe the lambda should receive a ref instead of an rvalue ref.
Zan Dobersek
Comment 3 2019-09-27 03:47:24 PDT
Comment on attachment 379545 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379545&action=review >> Source/WebCore/page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.cpp:183 >> + applyLayerPosition(*m_contentShadowLayer, rootContentsPosition); > > hmm position can't be moved, so maybe the lambda should receive a ref instead of an rvalue ref. 'position' values here are all FloatPoints -- nothing that would benefit from being moved instead of copied. 'auto&&' used in the lambda is there so that the lambda can operate on either an rvalue FloatPoint that's returned from FrameView functions or an lvalue reference like the one passed to the lambda here.
Zan Dobersek
Comment 4 2019-09-27 03:48:33 PDT
Comment on attachment 379545 [details] Patch Clearing flags on attachment: 379545 Committed r250420: <https://trac.webkit.org/changeset/250420>
Zan Dobersek
Comment 5 2019-09-27 03:48:39 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-09-27 03:49:14 PDT
<rdar://problem/55777405>
Note You need to log in before you can comment on or make changes to this bug.