Bug 202178 - Move schemes for SchemeRegistry from WebProcessPool to LegacyGlobalSettings
Summary: Move schemes for SchemeRegistry from WebProcessPool to LegacyGlobalSettings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-24 16:18 PDT by Alex Christensen
Modified: 2019-11-08 13:34 PST (History)
8 users (show)

See Also:

Attachments
Patch (20.79 KB, patch)
2019-09-24 16:20 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (9.95 KB, patch)
2019-11-07 14:39 PST, Alex Christensen 		youennf: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2019-09-24 16:18:50 PDT 
Move schemes for SchemeRegistry from WebProcessPool to LegacyGlobalSettings
Comment 1 Alex Christensen 2019-09-24 16:20:18 PDT 
Created attachment 379511 [details]
Patch
Comment 2 Tim Horton 2019-09-24 16:33:23 PDT 
This seems wrong for the case where there are multiple webkit clients in a given process
Comment 3 Alex Christensen 2019-11-07 14:39:41 PST 
Created attachment 383074 [details]
Patch
Comment 4 Alex Christensen 2019-11-08 03:29:00 PST 
(In reply to Tim Horton from comment #2)
> This seems wrong for the case where there are multiple webkit clients in a
> given process

This is SPI-only, it's only used from WKContextRegisterURLSchemeAsSecure and WKContextRegisterURLSchemeAsBypassingContentSecurityPolicy, and that one client intends them to be global.  If you think it would be significantly better I could deprecate those two SPIs and make a class method replacement, but I don't think that's necessary.
Comment 6 Radar WebKit Bug Importer 2019-11-08 13:18:16 PST 
<rdar://problem/57032146>
Comment 7 mitz 2019-11-08 13:34:13 PST 
Comment on attachment 383074 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383074&action=review

> Source/WebKit/ChangeLog:8
> +        The current users of the SPI to set these only have one WebProcessPool, so they intend these settings to be global.

What if there are other WebKit clients in the same address space that have their own process pools?