Bug 202167 - [iPadOS] [DataActivation] Focus moves away after focusing input fields on www.att.com
Summary: [iPadOS] [DataActivation] Focus moves away after focusing input fields on www...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-24 13:37 PDT by Wenson Hsieh
Modified: 2019-09-25 09:01 PDT (History)
11 users (show)

See Also:

Attachments
Patch (19.79 KB, patch)
2019-09-24 15:06 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Fix macOS builds (20.44 KB, patch)
2019-09-24 15:19 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Patch for landing (20.42 KB, patch)
2019-09-24 15:34 PDT, Wenson Hsieh 		wenson_hsieh: commit-queue+
Details | Formatted Diff | Diff
Patch for landing (20.42 KB, patch)
2019-09-24 15:35 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Patch (21.88 KB, patch)
2019-09-24 17:28 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2019-09-24 13:37:54 PDT 
<rdar://problem/55185021>
Comment 1 Wenson Hsieh 2019-09-24 15:06:07 PDT Comment hidden (obsolete)
Comment 2 Wenson Hsieh 2019-09-24 15:19:12 PDT 
Created attachment 379500 [details]
Fix macOS builds
Comment 3 Tim Horton 2019-09-24 15:29:01 PDT 
Comment on attachment 379500 [details]
Fix macOS builds

View in context: https://bugs.webkit.org/attachment.cgi?id=379500&action=review

> Source/WebKit/ChangeLog:48
> +        DataActivation. However, this also fixes various cases known bugs that are otherwise fixed in Safari only, via

various cases known bugs

> Source/WTF/wtf/spi/darwin/dyldSPI.h:49
> +#define DYLD_IOS_VERSION_13_1 0x000D0100

.2

> Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm:329
> +    static bool isDataActivation = applicationBundleIsEqualTo("com.apple.DataActivation"_s);

I have some bizarre vague recollection that there might be second bundle ID for some reason? Maybe not anymore.
Comment 4 Wenson Hsieh 2019-09-24 15:32:50 PDT 
Comment on attachment 379500 [details]
Fix macOS builds

View in context: https://bugs.webkit.org/attachment.cgi?id=379500&action=review

>> Source/WebKit/ChangeLog:48
>> +        DataActivation. However, this also fixes various cases known bugs that are otherwise fixed in Safari only, via
> 
> various cases known bugs

Fixed!

>> Source/WTF/wtf/spi/darwin/dyldSPI.h:49
>> +#define DYLD_IOS_VERSION_13_1 0x000D0100
> 
> .2

Fixed!

>> Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm:329
>> +    static bool isDataActivation = applicationBundleIsEqualTo("com.apple.DataActivation"_s);
> 
> I have some bizarre vague recollection that there might be second bundle ID for some reason? Maybe not anymore.

😧

(We chatted offline about this briefly, and it *appears* to no longer be the case)
Comment 5 Wenson Hsieh 2019-09-24 15:34:29 PDT Comment hidden (obsolete)
Comment 6 Wenson Hsieh 2019-09-24 15:35:24 PDT Comment hidden (obsolete)
Comment 7 Wenson Hsieh 2019-09-24 17:28:55 PDT 
Created attachment 379518 [details]
Patch
Comment 8 WebKit Commit Bot 2019-09-25 09:01:45 PDT 
Comment on attachment 379518 [details]
Patch

Clearing flags on attachment: 379518

Committed r250345: <https://trac.webkit.org/changeset/250345>
Comment 9 WebKit Commit Bot 2019-09-25 09:01:47 PDT 
All reviewed patches have been landed.  Closing bug.