Bring up queues for iPadOS Simulator Tests
<rdar://problem/55668296>
Created attachment 379460 [details] Patch This is ready for review, but I will be waiting to land until I have the hardware ready.
Comment on attachment 379460 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379460&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:213 > + "slavenames": ["bot667", "bot674"] We're doing Debug and Release....might these bots be better used? Seems like we shouldn't need both, given that ios-simulator already does both.
So after in person discussion, we are going to only bring up one of each Release and Debug.
Created attachment 379485 [details] Patch Removed 2 of the testers from the config update.
Comment on attachment 379485 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379485&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:56 > + "Apple iPadOS 13 Simulator Debug WK2 (Tests)": {platform: Dashboard.Platform.iPadOS13Simulator, debug: true, tester: true, testCategory: Buildbot.TestCategory.WebKit2}, Is iPadOS13Simulator already present in Dashboard.js? I don't think this will work without it. Alternatively, perhaps we should just add these to the iOS13Simulator platform since they rely on the same build products.
(In reply to Ryan Haddad from comment #6) > Comment on attachment 379485 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=379485&action=review > > > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:56 > > + "Apple iPadOS 13 Simulator Debug WK2 (Tests)": {platform: Dashboard.Platform.iPadOS13Simulator, debug: true, tester: true, testCategory: Buildbot.TestCategory.WebKit2}, > > Is iPadOS13Simulator already present in Dashboard.js? I don't think this > will work without it. > > Alternatively, perhaps we should just add these to the iOS13Simulator > platform since they rely on the same build products. Oh, good point, probably not
Created attachment 379489 [details] Patch Fixed Dashboard issue.
Comment on attachment 379489 [details] Patch It doesn't look like the new queues are being triggered by the iOS builders.
Created attachment 379490 [details] Patch Attempt number 2 at fixing the config.
Comment on attachment 379490 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379490&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:53 > "Apple iOS 13 Simulator Debug (Build)": {platform: Dashboard.Platform.iOS13Simulator, debug: true, builder: true, architecture: Buildbot.BuildArchitecture.SixtyFourBit}, Why no heading here?
Comment on attachment 379490 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379490&action=review >> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:53 >> "Apple iOS 13 Simulator Debug (Build)": {platform: Dashboard.Platform.iOS13Simulator, debug: true, builder: true, architecture: Buildbot.BuildArchitecture.SixtyFourBit}, > > Why no heading here? Matt said that's a builder, missed that fact.
Because that is a builder and not a tester. We are not making any changes there.
(In reply to Jonathan Bedard from comment #12) > Comment on attachment 379490 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=379490&action=review > > >> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:53 > >> "Apple iOS 13 Simulator Debug (Build)": {platform: Dashboard.Platform.iOS13Simulator, debug: true, builder: true, architecture: Buildbot.BuildArchitecture.SixtyFourBit}, > > > > Why no heading here? > > Matt said that's a builder, missed that fact. Beat me to my own comment. Ha.
Comment on attachment 379490 [details] Patch Hardware is ready, landing.
Comment on attachment 379490 [details] Patch Clearing flags on attachment: 379490 Committed r250327: <https://trac.webkit.org/changeset/250327>
All reviewed patches have been landed. Closing bug.