Bug 202146 - We should initialize WebProcessPool::m_hiddenPageThrottlingTimer before using it.
Summary: We should initialize WebProcessPool::m_hiddenPageThrottlingTimer before using...
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-24 08:49 PDT by Mark Lam
Modified: 2019-09-24 09:22 PDT (History)
4 users (show)

See Also:

Attachments
proposed patch. (3.15 KB, patch)
2019-09-24 08:54 PDT, Mark Lam 		mark.lam: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2019-09-24 08:49:24 PDT 
...
Comment 1 Mark Lam 2019-09-24 08:54:48 PDT 
Created attachment 379455 [details]
proposed patch.
Comment 2 Robin Morisset 2019-09-24 09:17:04 PDT 
Comment on attachment 379455 [details]
proposed patch.

r=me
Comment 3 Chris Dumez 2019-09-24 09:18:13 PDT 
Comment on attachment 379455 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=379455&action=review

> Source/WebKit/UIProcess/WebProcessPool.cpp:232
> +    , m_hiddenPageThrottlingAutoIncreasesCounter([this](RefCounterEvent) { m_hiddenPageThrottlingTimer.startOneShot(0_s); })

The RefCounter constructor does not run the lambda it is being given so I don't understand the problem.
Comment 4 Mark Lam 2019-09-24 09:22:03 PDT 
Comment on attachment 379455 [details]
proposed patch.

I think Chris meant to r- this patch.  This is not an issue after all.  I just didn't look carefully enough at the code.  Sorry for the noise.