RESOLVED FIXED 202134
[Windows][webkitpy] _apache_config_file_name_for_platform should take the system PHP version into account 
https://bugs.webkit.org/show_bug.cgi?id=202134
Summary [Windows][webkitpy] _apache_config_file_name_for_platform should take the sys...
Fujii Hironori
Reported 2019-09-23 23:32:49 PDT
_apache_config_file_name_for_platform always returns a config file name for php5 on Cygwin Python, one for php7 on Win32 Python.
Attachments
Patch (19.36 KB, patch)
2019-09-23 23:41 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch (19.47 KB, patch)
2019-09-24 00:03 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch (19.49 KB, patch)
2019-09-24 18:58 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2019-09-23 23:41:24 PDT
Created attachment 379434 [details] Patch
Fujii Hironori
Comment 2 2019-09-24 00:03:20 PDT
Created attachment 379437 [details] Patch
Jonathan Bedard
Comment 3 2019-09-24 13:43:21 PDT
Comment on attachment 379437 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379437&action=review > Tools/Scripts/webkitpy/port/base.py:1301 > + conf = self._filesystem.join(prefix, "php%sts.dll" % version) Can we use format() string since % won't work in Python 3 (I recognize that we use % all over this file, I'm working on the migration....I figure it's good not to add more, though)
Fujii Hironori
Comment 4 2019-09-24 18:58:03 PDT
Created attachment 379522 [details] Patch * Addressed the review feedback.
Fujii Hironori
Comment 5 2019-09-24 20:16:54 PDT
Comment on attachment 379522 [details] Patch Clearing flags on attachment: 379522 Committed r250330: <https://trac.webkit.org/changeset/250330>
Fujii Hironori
Comment 6 2019-09-24 20:16:58 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-09-24 22:48:26 PDT
<rdar://problem/55692444>
Note You need to log in before you can comment on or make changes to this bug.