Bug 202134 - [Windows][webkitpy] _apache_config_file_name_for_platform should take the system PHP version into account
Summary: [Windows][webkitpy] _apache_config_file_name_for_platform should take the sys...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-23 23:32 PDT by Fujii Hironori
Modified: 2019-09-24 22:48 PDT (History)
9 users (show)

See Also:

Attachments
Patch (19.36 KB, patch)
2019-09-23 23:41 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Patch (19.47 KB, patch)
2019-09-24 00:03 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Patch (19.49 KB, patch)
2019-09-24 18:58 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2019-09-23 23:32:49 PDT 
_apache_config_file_name_for_platform always returns a config
file name for php5 on Cygwin Python, one for php7 on Win32
Python.
Comment 1 Fujii Hironori 2019-09-23 23:41:24 PDT 
Created attachment 379434 [details]
Patch
Comment 2 Fujii Hironori 2019-09-24 00:03:20 PDT 
Created attachment 379437 [details]
Patch
Comment 3 Jonathan Bedard 2019-09-24 13:43:21 PDT 
Comment on attachment 379437 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379437&action=review

> Tools/Scripts/webkitpy/port/base.py:1301
> +            conf = self._filesystem.join(prefix, "php%sts.dll" % version)

Can we use format() string since % won't work in Python 3 (I recognize that we use % all over this file, I'm working on the migration....I figure it's good not to add more, though)
Comment 4 Fujii Hironori 2019-09-24 18:58:03 PDT 
Created attachment 379522 [details]
Patch

* Addressed the review feedback.
Comment 5 Fujii Hironori 2019-09-24 20:16:54 PDT 
Comment on attachment 379522 [details]
Patch

Clearing flags on attachment: 379522

Committed r250330: <https://trac.webkit.org/changeset/250330>
Comment 6 Fujii Hironori 2019-09-24 20:16:58 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-09-24 22:48:26 PDT 
<rdar://problem/55692444>