See https://bugs.webkit.org/show_bug.cgi?id=202085#c14.
Created attachment 379436 [details] proposed patch.
Comment on attachment 379436 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=379436&action=review > Source/JavaScriptCore/runtime/CellSize.h:36 > +inline size_t cellSize(VM& vm, JSCell* cell) why not put isDynamicallySizedType in here too? > Source/JavaScriptCore/runtime/CellSize.h:65 > + default: ASSERT(!isDynamicallySizedType(cell))?
Comment on attachment 379436 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=379436&action=review >> Source/JavaScriptCore/runtime/CellSize.h:36 >> +inline size_t cellSize(VM& vm, JSCell* cell) > > why not put isDynamicallySizedType in here too? I was thinking it belongs in JSType.h, but now that you mentioned it, it does pertain to cell sizing. I'll move it here. >> Source/JavaScriptCore/runtime/CellSize.h:65 >> + default: > > ASSERT(!isDynamicallySizedType(cell))? I'll just put this whole switch statement in a "if (isDynamicallySizedType(cell))" instead. That will allow me to put a RELEASE_ASSERT_NOT_REACHED() in the default case.
Created attachment 379438 [details] patch for landing.
Thanks for the review. Landed in r250289: <http://trac.webkit.org/r250289>.
<rdar://problem/55653382>