Bug 202131 - Import navigation-timing WPT tests that don't time out
Summary: Import navigation-timing WPT tests that don't time out
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-23 22:11 PDT by Alex Christensen
Modified: 2019-09-24 07:11 PDT (History)
3 users (show)

See Also:


Attachments
Patch (157.10 KB, patch)
2019-09-23 22:12 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2019-09-23 22:11:26 PDT
Import navigation-timing WPT tests that don't time out
Comment 1 Alex Christensen 2019-09-23 22:12:22 PDT
Created attachment 379430 [details]
Patch
Comment 2 youenn fablet 2019-09-24 05:36:06 PDT
Comment on attachment 379430 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379430&action=review

> LayoutTests/imported/w3c/ChangeLog:3
> +        Import navigation-timing WPT tests that don't time out

It might be simpler to import all navigation-timing tests and skip the ones that time out.
That way, next import will be much easier.
Or update import-expectations.json to never import these tests if we really thing they are no good.

> LayoutTests/imported/w3c/web-platform-tests/navigation-timing/nav2_test_redirect_chain_xserver_partial_opt_in-expected.txt:1
> +Blocked access to external URL http://www.localhost:8800/common/redirect.py?location=http://www.localhost:8800/common/redirect-opt-in.py?location=http://localhost:8800/navigation-timing/resources/blank_page_green.html

We probably need to update this test to use hosts[alt]

> LayoutTests/imported/w3c/web-platform-tests/navigation-timing/nav2_test_redirect_chain_xserver_partial_opt_in.html:50
> +            const destUrl = make_absolute_url({subdomain: "www",

Probably here we should move out of www subdomain.
Might be best done as a follow-up so that we can upstream it to WPT.

> LayoutTests/imported/w3c/web-platform-tests/navigation-timing/nav2_test_redirect_xserver-expected.txt:1
> +Blocked access to external URL http://www.localhost:8800/common/redirect.py?location=http://localhost:8800/navigation-timing/resources/blank_page_green.html

Ditto here.
Comment 3 Alex Christensen 2019-09-24 06:21:02 PDT
Comment on attachment 379430 [details]
Patch

Next import will be easier because they will all not timeout.
Comment 4 WebKit Commit Bot 2019-09-24 07:10:02 PDT
Comment on attachment 379430 [details]
Patch

Clearing flags on attachment: 379430

Committed r250293: <https://trac.webkit.org/changeset/250293>
Comment 5 WebKit Commit Bot 2019-09-24 07:10:04 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-09-24 07:11:22 PDT
<rdar://problem/55661571>