Bug 202131 – Import navigation-timing WPT tests that don't time out

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alex Christensen]

Import navigation-timing WPT tests that don't time out

[Alex Christensen]

Created attachment 379430 [details]
Patch

[youenn fablet]

Comment on attachment 379430 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379430&action=review

> LayoutTests/imported/w3c/ChangeLog:3
> +        Import navigation-timing WPT tests that don't time out

It might be simpler to import all navigation-timing tests and skip the ones that time out.
That way, next import will be much easier.
Or update import-expectations.json to never import these tests if we really thing they are no good.

> LayoutTests/imported/w3c/web-platform-tests/navigation-timing/nav2_test_redirect_chain_xserver_partial_opt_in-expected.txt:1
> +Blocked access to external URL http://www.localhost:8800/common/redirect.py?location=http://www.localhost:8800/common/redirect-opt-in.py?location=http://localhost:8800/navigation-timing/resources/blank_page_green.html

We probably need to update this test to use hosts[alt]

> LayoutTests/imported/w3c/web-platform-tests/navigation-timing/nav2_test_redirect_chain_xserver_partial_opt_in.html:50
> +            const destUrl = make_absolute_url({subdomain: "www",

Probably here we should move out of www subdomain.
Might be best done as a follow-up so that we can upstream it to WPT.

> LayoutTests/imported/w3c/web-platform-tests/navigation-timing/nav2_test_redirect_xserver-expected.txt:1
> +Blocked access to external URL http://www.localhost:8800/common/redirect.py?location=http://localhost:8800/navigation-timing/resources/blank_page_green.html

Ditto here.

[Alex Christensen]

Comment on attachment 379430 [details]
Patch

Next import will be easier because they will all not timeout.

[WebKit Commit Bot]

Comment on attachment 379430 [details]
Patch

Clearing flags on attachment: 379430

Committed r250293: <https://trac.webkit.org/changeset/250293>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/55661571>