Bug 20213 – colspan in table-layout:fixed does not add up widths properly

• Status: RESOLVED
• Resolution: FIXED
• Component: Tables

[Eric Roman]

When columns widths are specified via <colgroup> on a table-layout:fixed,
a TD with colspan=N is getting width N*<first-col-spanned> rather than sum(<i-th col spanned).

I observed this problem on the site:
http://www.megafonmoscow.ru/

IE7, Firefox 2, Firefox 3, Opera 9 render correctly.
Safari 3.1 and WebKit r35417 have this problem.

Will attach repro case.

[Eric Roman]

Created attachment 22542 [details]
In WebKit the TABLE overflows the containing red DIV

[Eric Roman]

This could be a dupe of one of the existing bugs. These all sound related:

https://bugs.webkit.org/show_bug.cgi?id=18260
https://bugs.webkit.org/show_bug.cgi?id=15111
https://bugs.webkit.org/show_bug.cgi?id=14858

[Julien Chaffraix]

This bug was fixed: we now match Firefox and Opera when computing the cell with the colspan.

I think it was fixed by bug 14858, though I haven't bisected so it's only a guess. The previous bug landed coverage for auto table layout but not for fixed table layout. As this impacted a web-site, taking the bug to land some coverage.

[Julien Chaffraix]

Created attachment 148030 [details]
Proposed patch, land the test case.

[Abhishek Arya]

Comment on attachment 148030 [details]
Proposed patch, land the test case.

View in context: https://bugs.webkit.org/attachment.cgi?id=148030&action=review

> LayoutTests/ChangeLog:8
> +        The bug has been fixed (likely by bug 14858) so landing the test case as the combinaison of fixed table layout

typo 'combinaison'

> LayoutTests/fast/table/fixed-table-layout/fixed-layout-column-colspan-wrong-size.html:33
> +    <colgroup>

nit: indent of table children to the right.

[Julien Chaffraix]

Created attachment 148031 [details]
Patch for landing

[Abhishek Arya]

forgot the typo Sir :(

[Julien Chaffraix]

Created attachment 148033 [details]
Patch for landing

[Julien Chaffraix]

(In reply to comment #7)
> forgot the typo Sir :(

Damn, I thought I changed that but no luck. As you can see, I don't know how to spell this word properly in English so I have reworked the ChangeLog not to use it.

[WebKit Review Bot]

Comment on attachment 148033 [details]
Patch for landing

Clearing flags on attachment: 148033

Committed r120560: <http://trac.webkit.org/changeset/120560>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.