Bug 20213 - colspan in table-layout:fixed does not add up widths properly
Summary: colspan in table-layout:fixed does not add up widths properly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tables (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Julien Chaffraix
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-29 12:32 PDT by Eric Roman
Modified: 2012-06-17 19:22 PDT (History)
4 users (show)

See Also:

Attachments
In WebKit the TABLE overflows the containing red DIV (528 bytes, text/html)
2008-07-29 12:34 PDT, Eric Roman 		no flags Details
Proposed patch, land the test case. (3.02 KB, patch)
2012-06-17 16:29 PDT, Julien Chaffraix 		no flags Details | Formatted Diff | Diff
Patch for landing (3.27 KB, patch)
2012-06-17 18:00 PDT, Julien Chaffraix 		no flags Details | Formatted Diff | Diff
Patch for landing (3.30 KB, patch)
2012-06-17 18:26 PDT, Julien Chaffraix 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Roman 2008-07-29 12:32:27 PDT 
When columns widths are specified via <colgroup> on a table-layout:fixed,
a TD with colspan=N is getting width N*<first-col-spanned> rather than sum(<i-th col spanned).

I observed this problem on the site:
http://www.megafonmoscow.ru/

IE7, Firefox 2, Firefox 3, Opera 9 render correctly.
Safari 3.1 and WebKit r35417 have this problem.

Will attach repro case.
Comment 1 Eric Roman 2008-07-29 12:34:26 PDT 
Created attachment 22542 [details]
In WebKit the TABLE overflows the containing red DIV
Comment 2 Eric Roman 2008-07-29 12:39:07 PDT 
This could be a dupe of one of the existing bugs. These all sound related:

https://bugs.webkit.org/show_bug.cgi?id=18260
https://bugs.webkit.org/show_bug.cgi?id=15111
https://bugs.webkit.org/show_bug.cgi?id=14858
Comment 3 Julien Chaffraix 2012-06-17 15:52:49 PDT 
This bug was fixed: we now match Firefox and Opera when computing the cell with the colspan.

I think it was fixed by bug 14858, though I haven't bisected so it's only a guess. The previous bug landed coverage for auto table layout but not for fixed table layout. As this impacted a web-site, taking the bug to land some coverage.
Comment 4 Julien Chaffraix 2012-06-17 16:29:34 PDT 
Created attachment 148030 [details]
Proposed patch, land the test case.
Comment 5 Abhishek Arya 2012-06-17 16:37:02 PDT 
Comment on attachment 148030 [details]
Proposed patch, land the test case.

View in context: https://bugs.webkit.org/attachment.cgi?id=148030&action=review

> LayoutTests/ChangeLog:8
> +        The bug has been fixed (likely by bug 14858) so landing the test case as the combinaison of fixed table layout

typo 'combinaison'

> LayoutTests/fast/table/fixed-table-layout/fixed-layout-column-colspan-wrong-size.html:33
> +    <colgroup>

nit: indent of table children to the right.
Comment 6 Julien Chaffraix 2012-06-17 18:00:59 PDT 
Created attachment 148031 [details]
Patch for landing
Comment 7 Abhishek Arya 2012-06-17 18:02:45 PDT 
forgot the typo Sir :(
Comment 8 Julien Chaffraix 2012-06-17 18:26:20 PDT 
Created attachment 148033 [details]
Patch for landing
Comment 9 Julien Chaffraix 2012-06-17 18:28:23 PDT 
(In reply to comment #7)
> forgot the typo Sir :(

Damn, I thought I changed that but no luck. As you can see, I don't know how to spell this word properly in English so I have reworked the ChangeLog not to use it.
Comment 10 WebKit Review Bot 2012-06-17 19:22:31 PDT 
Comment on attachment 148033 [details]
Patch for landing

Clearing flags on attachment: 148033

Committed r120560: <http://trac.webkit.org/changeset/120560>
Comment 11 WebKit Review Bot 2012-06-17 19:22:36 PDT 
All reviewed patches have been landed.  Closing bug.