Bug 202125 – Update selections after scrolling for iframes and hide selections while iframes and overflow scrolls are scrolling.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Megan Gardner]

Update selection scrolls for iframes and hide selections while iframs and overflow scrolls are scrolling.

[Megan Gardner]

Created attachment 379415 [details]
Patch

[EWS Watchlist]

Comment on attachment 379415 [details]
Patch

Attachment 379415 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/13062438

New failing tests:
storage/indexeddb/modern/new-database-after-user-delete.html

[EWS Watchlist]

Created attachment 379427 [details]
Archive of layout-test-results from ews213 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews213  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[Megan Gardner]

Created attachment 379498 [details]
Patch

[Megan Gardner]

<rdar://problem/14944104>

[Megan Gardner]

Created attachment 379523 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 379523 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379523&action=review

> Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp:349
> +    if (!frameViewPtr->frame().isMainFrame()) {
> +        if (scrollingLayerPositionAction == ScrollingLayerPositionAction::Set)
> +            m_page->editorClient().overflowScrollPositionChanged();
> +    }

If this is called for subframes, then "overflowScrollPositionChanged" is mis-named.

[Tim Horton]

It’s true, though that mistake is made in many places. But maybe we don’t need to make it in WebCore. (Even worse right now WebKit->UIKit calls main frame scrolls to be “overflow”, which is part of what this is fixing).

[Megan Gardner]

Created attachment 379578 [details]
Patch

[Tim Horton]

We can fix the names in WebKit in a future patch (maybe we need a word for “I frame or overflow”? I say “sub scrollable region” but I don’t know that we ever say that in the code).

[WebKit Commit Bot]

Comment on attachment 379578 [details]
Patch

Clearing flags on attachment: 379578

Committed r250365: <https://trac.webkit.org/changeset/250365>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Fujii Hironori]

Committed r250374: <https://trac.webkit.org/changeset/250374>