Bug 202100 - [Nicosia] Add implementations for fixed, positioned, sticky ScrollingTreeNodes
Summary: [Nicosia] Add implementations for fixed, positioned, sticky ScrollingTreeNodes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords: InRadar
Depends on:
Blocks: 198475
  Show dependency tree / graph
 
Reported: 2019-09-23 03:02 PDT by Zan Dobersek
Modified: 2019-09-25 02:48 PDT (History)
13 users (show)

See Also:

Attachments
Patch (24.85 KB, patch)
2019-09-23 03:23 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch for landing (24.73 KB, patch)
2019-09-25 02:46 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2019-09-23 03:02:09 PDT 
[Nicosia] Add implementations for fixed, positioned, sticky ScrollingTreeNodes
Comment 1 Zan Dobersek 2019-09-23 03:23:29 PDT 
Created attachment 379363 [details]
Patch
Comment 2 Carlos Garcia Campos 2019-09-24 04:17:43 PDT 
Comment on attachment 379363 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379363&action=review

> Source/WebCore/page/scrolling/nicosia/ScrollingTreePositionedNode.cpp:88
> +        }();

What's the point of the lambda here?

> Source/WebCore/page/scrolling/nicosia/ScrollingTreePositionedNode.h:43
> +class ScrollingTreePositionedNode : public ScrollingTreeNode {

is this final class?
Comment 3 Zan Dobersek 2019-09-24 05:46:29 PDT 
Comment on attachment 379363 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379363&action=review

>> Source/WebCore/page/scrolling/nicosia/ScrollingTreePositionedNode.cpp:88
>> +        }();
> 
> What's the point of the lambda here?

OK, I'll flatten it.
Comment 4 Zan Dobersek 2019-09-25 02:46:52 PDT 
Created attachment 379533 [details]
Patch for landing
Comment 5 Zan Dobersek 2019-09-25 02:47:52 PDT 
Comment on attachment 379533 [details]
Patch for landing

Clearing flags on attachment: 379533

Committed r250339: <https://trac.webkit.org/changeset/250339>
Comment 6 Zan Dobersek 2019-09-25 02:47:56 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-09-25 02:48:19 PDT 
<rdar://problem/55697583>