Bug 20210 – Console groups are incorrect when closing and reopening the Inspector

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Timothy Hatcher]

When closing and reopening the inspector the console groups are messed up and in the wrong order and logs are lumped into the last group. See the attached screenshot and test.

Steps:
1) Load the test case.
2) Open the inspector's console.

Results:
Notice the order of the groups does not match the file.

Reloading the page while the inspector is open gives the correct results.

[Timothy Hatcher]

Created attachment 22539 [details]
Expected Results

[Timothy Hatcher]

Created attachment 22540 [details]
Actual Results

[Timothy Hatcher]

Created attachment 22541 [details]
Test Case

[Timothy Hatcher]

Also in the messed up state, expanding/collapsing one of the top level groups, toggles all of the groups in that level, not just the clicked one.

[Keishi Hattori]

Created attachment 22726 [details]
patch

I forgot to test for this in the way. This fixes the issue. I realized you can't properly do this without recording where the group ended, so now there's StartGroup and EndGroup message levels.

[Timothy Hatcher]

Comment on attachment 22726 [details]
patch

Better ChangeLog!

The patch seems technically correct, but there are some style issues.

+    //if (arguments.isEmpty())
+    //    addConsoleMessage(new ConsoleMessage(source, StartGroupMessageLevel, exec, String(), lineNumber, sourceURL, m_groupLevel));
+    //else

We don't comment out code. Just remove it.

Attach a new patch that removes this and i'll r+ it.

[Keishi Hattori]

Created attachment 22793 [details]
removed commented out code

[Timothy Hatcher]

Landed in r35788.