Bug 20210 - Console groups are incorrect when closing and reopening the Inspector
: Console groups are incorrect when closing and reopening the Inspector
Status: RESOLVED FIXED
: WebKit
Web Inspector (Deprecated)
: 528+ (Nightly build)
: All All
: P1 Critical
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2008-07-29 11:15 PST by
Modified: 2008-08-15 10:48 PST (History)


Attachments
Expected Results (3.05 KB, image/png)
2008-07-29 11:15 PST, Timothy Hatcher
no flags Details
Actual Results (2.73 KB, image/png)
2008-07-29 11:19 PST, Timothy Hatcher
no flags Details
Test Case (263 bytes, text/html)
2008-07-29 11:19 PST, Timothy Hatcher
no flags Details
patch (8.73 KB, patch)
2008-08-11 06:18 PST, Keishi Hattori
timothy: review-
Review Patch | Details | Formatted Diff | Diff
removed commented out code (7.55 KB, patch)
2008-08-14 08:44 PST, Keishi Hattori
timothy: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2008-07-29 11:15:02 PST
When closing and reopening the inspector the console groups are messed up and in the wrong order and logs are lumped into the last group. See the attached screenshot and test.

Steps:
1) Load the test case.
2) Open the inspector's console.

Results:
Notice the order of the groups does not match the file.

Reloading the page while the inspector is open gives the correct results.
------- Comment #1 From 2008-07-29 11:15:44 PST -------
Created an attachment (id=22539) [details]
Expected Results
------- Comment #2 From 2008-07-29 11:19:01 PST -------
Created an attachment (id=22540) [details]
Actual Results
------- Comment #3 From 2008-07-29 11:19:23 PST -------
Created an attachment (id=22541) [details]
Test Case
------- Comment #4 From 2008-07-29 11:20:08 PST -------
Also in the messed up state, expanding/collapsing one of the top level groups, toggles all of the groups in that level, not just the clicked one.
------- Comment #5 From 2008-08-11 06:18:10 PST -------
Created an attachment (id=22726) [details]
patch

I forgot to test for this in the way. This fixes the issue. I realized you can't properly do this without recording where the group ended, so now there's StartGroup and EndGroup message levels.
------- Comment #6 From 2008-08-13 00:28:42 PST -------
(From update of attachment 22726 [details])
Better ChangeLog!

The patch seems technically correct, but there are some style issues.

+    //if (arguments.isEmpty())
+    //    addConsoleMessage(new ConsoleMessage(source, StartGroupMessageLevel, exec, String(), lineNumber, sourceURL, m_groupLevel));
+    //else

We don't comment out code. Just remove it.

Attach a new patch that removes this and i'll r+ it.
------- Comment #7 From 2008-08-14 08:44:36 PST -------
Created an attachment (id=22793) [details]
removed commented out code
------- Comment #8 From 2008-08-15 10:48:57 PST -------
Landed in r35788.