Bug 202099 - testmasm: integer operands loaded as unsigned values
Summary: testmasm: integer operands loaded as unsigned values
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-23 01:15 PDT by Zan Dobersek
Modified: 2019-09-23 07:09 PDT (History)
8 users (show)

See Also:

Attachments
Patch (4.43 KB, patch)
2019-09-23 01:21 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2019-09-23 01:15:52 PDT 
testmasm: integer operands loaded as unsigned values
Comment 1 Zan Dobersek 2019-09-23 01:20:05 PDT 
../../Source/JavaScriptCore/assembler/testmasm.cpp: In function ‘void {anonymous}::testBranchTestBit32RegReg()’:
../../Source/JavaScriptCore/assembler/testmasm.cpp:105:23: warning: comparison of integer expressions of different signedness: ‘int’ and ‘uint32_t’ {aka ‘unsigned int’} [-Wsign-compare]
         if ((_actual) == (_expected))                                   \
             ~~~~~~~~~~^~~~~~~~~~~~~~
../../Source/JavaScriptCore/assembler/testmasm.cpp:105:23: note: in definition of macro ‘CHECK_EQ’
         if ((_actual) == (_expected))                                   \
                       ^~
Comment 2 Zan Dobersek 2019-09-23 01:21:49 PDT 
Created attachment 379360 [details]
Patch
Comment 3 Mark Lam 2019-09-23 07:01:32 PDT 
Comment on attachment 379360 [details]
Patch

r=me
Comment 4 Zan Dobersek 2019-09-23 07:08:10 PDT 
Comment on attachment 379360 [details]
Patch

Clearing flags on attachment: 379360

Committed r250232: <https://trac.webkit.org/changeset/250232>
Comment 5 Zan Dobersek 2019-09-23 07:08:14 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-09-23 07:09:20 PDT 
<rdar://problem/55621894>