Bug 202097 – AudioTrackPrivateMediaStreamCocoa does not need to manipulate the audio unit in play/pause methods

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

AudioTrackPrivateMediaStreamCocoa does not need to manipulate the audio unit in play/pause methods

[youenn fablet]

Created attachment 379357 [details]
Patch

[youenn fablet]

<rdar://problem/51548144>

[Eric Carlson]

Comment on attachment 379357 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379357&action=review

> Source/WebCore/platform/mediastream/mac/AudioTrackPrivateMediaStreamCocoa.h:89
> +    bool m_isTransitioningToPausing { false };
> +    bool m_isTransitioningToPlaying { false };

Couldn't we replace these with an enum? In a case where both are set simultaneously, wouldn't we always want the last one set to always "win"?

[youenn fablet]

Created attachment 379369 [details]
Patch

[youenn fablet]

> Couldn't we replace these with an enum? In a case where both are set
> simultaneously, wouldn't we always want the last one set to always "win"?

I tried to come up with a new approach without any transition values.

[Eric Carlson]

Comment on attachment 379369 [details]
Patch

Nice approach! 

r=me once the bots are happy.

[youenn fablet]

Created attachment 379433 [details]
Patch

[youenn fablet]

(In reply to youenn fablet from comment #7)
> Created attachment 379433 [details]
> Patch

Added some logging in case of failing to start the audio unit.

[WebKit Commit Bot]

Comment on attachment 379433 [details]
Patch

Clearing flags on attachment: 379433

Committed r250290: <https://trac.webkit.org/changeset/250290>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.