Bug 202094 - WebPage::sessionID() does not need to get the sessionID from there WebCore Page
Summary: WebPage::sessionID() does not need to get the sessionID from there WebCore Page
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-22 19:06 PDT by Chris Dumez
Modified: 2019-09-23 09:32 PDT (History)
7 users (show)

See Also:

Attachments
Patch (2.74 KB, patch)
2019-09-22 19:07 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (2.95 KB, patch)
2019-09-23 08:22 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-09-22 19:06:08 PDT 
WebPage::sessionID() does not need to get the sessionID from there WebCore Page.
Comment 1 Chris Dumez 2019-09-22 19:07:48 PDT 
Created attachment 379351 [details]
Patch
Comment 2 youenn fablet 2019-09-22 22:48:50 PDT 
Comment on attachment 379351 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379351&action=review

> Source/WebKit/WebProcess/WebPage/WebPage.h:297
>      bool usesEphemeralSession() const { return m_page->usesEphemeralSession(); }

Can we fix usesEphemeralSession() as well?
Comment 3 Chris Dumez 2019-09-23 08:22:16 PDT 
Created attachment 379370 [details]
Patch
Comment 4 Chris Dumez 2019-09-23 08:38:37 PDT 
(In reply to youenn fablet from comment #2)
> Comment on attachment 379351 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=379351&action=review
> 
> > Source/WebKit/WebProcess/WebPage/WebPage.h:297
> >      bool usesEphemeralSession() const { return m_page->usesEphemeralSession(); }
> 
> Can we fix usesEphemeralSession() as well?

Good catch, fixed.
Comment 5 WebKit Commit Bot 2019-09-23 09:31:22 PDT 
Comment on attachment 379370 [details]
Patch

Clearing flags on attachment: 379370

Committed r250236: <https://trac.webkit.org/changeset/250236>
Comment 6 WebKit Commit Bot 2019-09-23 09:31:23 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-09-23 09:32:27 PDT 
<rdar://problem/55625642>