Bug 202080 - Reduce use of SessionID::defaultSessionID() in WebKit
Summary: Reduce use of SessionID::defaultSessionID() in WebKit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-21 14:29 PDT by Chris Dumez
Modified: 2019-09-21 23:05 PDT (History)
13 users (show)

See Also:

Attachments
Patch (36.84 KB, patch)
2019-09-21 14:32 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (36.96 KB, patch)
2019-09-21 22:13 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-09-21 14:29:13 PDT 
Reduce use of SessionID::defaultSessionID() in WebKit.
Comment 1 Chris Dumez 2019-09-21 14:32:01 PDT 
Created attachment 379322 [details]
Patch
Comment 2 Alex Christensen 2019-09-21 21:35:55 PDT 
Comment on attachment 379322 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379322&action=review

> Source/WebCore/Modules/websockets/WebSocketChannel.cpp:109
> +    if (frame && page) {

We should probably return ConnectStatus::KO if this is false.
Comment 3 Chris Dumez 2019-09-21 21:54:41 PDT 
Comment on attachment 379322 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379322&action=review

>> Source/WebCore/Modules/websockets/WebSocketChannel.cpp:109
>> +    if (frame && page) {
> 
> We should probably return ConnectStatus::KO if this is false.

I was worried about changing behavior in a refactoring patch but I can try.
Comment 4 Chris Dumez 2019-09-21 22:13:12 PDT 
Created attachment 379338 [details]
Patch
Comment 5 Chris Dumez 2019-09-21 23:04:52 PDT 
Comment on attachment 379338 [details]
Patch

Clearing flags on attachment: 379338

Committed r250196: <https://trac.webkit.org/changeset/250196>
Comment 6 Chris Dumez 2019-09-21 23:04:54 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-09-21 23:05:17 PDT 
<rdar://problem/55597185>