Bug 202075 - clip-path: <geometry-box> mapping incorrect
Summary: clip-path: <geometry-box> mapping incorrect
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Schulze
Keywords: InRadar
Depends on:
Blocks: 126207
  Show dependency treegraph
Reported: 2019-09-21 02:19 PDT by Dirk Schulze
Modified: 2019-10-07 11:36 PDT (History)
10 users (show)

See Also:

Patch (3.55 KB, patch)
2019-09-21 09:37 PDT, Dirk Schulze
no flags Details | Formatted Diff | Diff
Patch (9.17 KB, patch)
2019-09-23 09:35 PDT, Dirk Schulze
no flags Details | Formatted Diff | Diff
Patch for landing (9.01 KB, patch)
2019-10-05 09:23 PDT, Dirk Schulze
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Schulze 2019-09-21 02:19:59 PDT
The mapping of the <geometry-box> for clip-path is implemented differently than in the spec: https://drafts.fxtf.org/css-masking-1/#the-clip-path

Spec changed after requests of the CSS WG to match the mapping in Fill And Stroke and CSS Transform spec.

Comment 1 Dirk Schulze 2019-09-21 09:37:39 PDT
Created attachment 379318 [details]
Comment 2 Dirk Schulze 2019-09-21 10:04:34 PDT
Hm. Seems like we don’t have tests in place for this change. All bots are green. Will upload a test.
Comment 3 Darin Adler 2019-09-21 11:33:28 PDT
Comment on attachment 379318 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=379318&action=review

> Source/WebCore/ChangeLog:14
> +        Covered by existing tests.

If this is covered by existing tests, then why wasn’t there a failing test that changes to succeeding when we fix the bug?
Comment 4 Darin Adler 2019-09-21 11:33:45 PDT
Oh, I see your comment now, sorry!
Comment 5 Dirk Schulze 2019-09-23 09:35:42 PDT
Created attachment 379375 [details]
Comment 6 Nikolas Zimmermann 2019-09-24 09:40:25 PDT
Comment on attachment 379375 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=379375&action=review


> Source/WebCore/rendering/shapes/BoxShape.cpp:86
> +    // stroke, view-box compute to border-box for HTML elements.

Comment 7 Simon Fraser (smfr) 2019-10-02 14:55:12 PDT
Comment on attachment 379375 [details]

This looks like it conflicts with your other patch.
Comment 8 Dirk Schulze 2019-10-05 09:23:36 PDT
Created attachment 380286 [details]
Patch for landing
Comment 9 Dirk Schulze 2019-10-05 09:25:49 PDT
Similar to https://bugs.webkit.org/show_bug.cgi?id=201892 Not sure if I don't have committer rights anymore (last path last year) or if there is a mistake in the contributions.json file. Simon, could you cq+ please?
Comment 10 WebKit Commit Bot 2019-10-07 11:35:07 PDT
Comment on attachment 380286 [details]
Patch for landing

Clearing flags on attachment: 380286

Committed r250778: <https://trac.webkit.org/changeset/250778>
Comment 11 WebKit Commit Bot 2019-10-07 11:35:08 PDT
All reviewed patches have been landed.  Closing bug.
Comment 12 Radar WebKit Bug Importer 2019-10-07 11:36:17 PDT