Bug 202062 - [FTW] Resolve crashes found while running canvas tests
Summary: [FTW] Resolve crashes found while running canvas tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-20 16:49 PDT by Brent Fulgham
Modified: 2019-09-21 19:41 PDT (History)
7 users (show)

See Also:

Attachments
Patch (24.04 KB, patch)
2019-09-20 17:12 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2019-09-20 16:49:52 PDT 
The canvas Layout tests revealed roughly 24 crashes.

This patch corrects a number of problems:

1. BitmapImage cannot create ID2D1Bitmaps without a render target. However, some code paths allowed a nullptr target to be used.
2. Direct2D will not allow you to draw an ID2D1Bitmap to itself. We need to create a copy.
3. Consolidate the empty 'State' class in PlatformContextDirect2D with the separate stack of rendering state. This was cruft left over from before the PlatformContextDirect2D code was in place. This simplifies a lot of the code, and avoids some cases where the stacks were not in sync.
Comment 1 Brent Fulgham 2019-09-20 17:12:29 PDT 
Created attachment 379287 [details]
Patch
Comment 2 Brent Fulgham 2019-09-20 17:18:00 PDT 
With the patch there are no crashes (but 145 failures!). Fixing failures next.
Comment 3 WebKit Commit Bot 2019-09-21 19:40:50 PDT 
Comment on attachment 379287 [details]
Patch

Clearing flags on attachment: 379287

Committed r250188: <https://trac.webkit.org/changeset/250188>
Comment 4 WebKit Commit Bot 2019-09-21 19:40:51 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-09-21 19:41:20 PDT 
<rdar://problem/55595290>