Bug 202059 - Move HSTS storage directory to LegacyGlobalSettings
Summary: Move HSTS storage directory to LegacyGlobalSettings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-20 14:55 PDT by Alex Christensen
Modified: 2019-09-24 16:33 PDT (History)
8 users (show)

See Also:

Attachments
Patch (5.69 KB, patch)
2019-09-20 14:55 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (6.80 KB, patch)
2019-09-20 23:04 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (6.98 KB, patch)
2019-09-24 06:28 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (6.98 KB, patch)
2019-09-24 06:33 PDT, Alex Christensen 		thorton: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2019-09-20 14:55:22 PDT 
Move HSTS storage directory to LegacyGlobalSettings
Comment 1 Alex Christensen 2019-09-20 14:55:53 PDT 
Created attachment 379273 [details]
Patch
Comment 2 Alex Christensen 2019-09-20 23:04:04 PDT 
Created attachment 379309 [details]
Patch
Comment 3 EWS Watchlist 2019-09-20 23:04:36 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 4 Carlos Garcia Campos 2019-09-23 02:47:46 PDT 
Comment on attachment 379309 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379309&action=review

> Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp:-331
> -    if (!webkit_website_data_manager_is_ephemeral(priv->websiteDataManager.get()))
> -        configuration.setHSTSStorageDirectory(FileSystem::stringFromFileSystemRepresentation(webkit_website_data_manager_get_hsts_cache_directory(priv->websiteDataManager.get())));

I guess we still need to set this in LegacyGlobalSettings to keep it working for now.
Comment 5 Alex Christensen 2019-09-24 06:28:13 PDT 
Created attachment 379443 [details]
Patch
Comment 6 Alex Christensen 2019-09-24 06:29:35 PDT 
All right.  It would probably be beneficial for gtk to move it to not have anything to do with LegacyGlobalSettings, but that's your decision.
Comment 7 Alex Christensen 2019-09-24 06:33:42 PDT 
Created attachment 379445 [details]
Patch
Comment 8 Alex Christensen 2019-09-24 11:54:50 PDT 
http://trac.webkit.org/r250312
Comment 9 Radar WebKit Bug Importer 2019-09-24 11:55:19 PDT 
<rdar://problem/55671318>
Comment 10 Tim Horton 2019-09-24 16:33:35 PDT 
This seems wrong for the case where there are multiple webkit clients in a given process