RESOLVED FIXED 202059
Move HSTS storage directory to LegacyGlobalSettings 
https://bugs.webkit.org/show_bug.cgi?id=202059
Summary Move HSTS storage directory to LegacyGlobalSettings
Alex Christensen
Reported 2019-09-20 14:55:22 PDT
Move HSTS storage directory to LegacyGlobalSettings
Attachments
Patch (5.69 KB, patch)
2019-09-20 14:55 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (6.80 KB, patch)
2019-09-20 23:04 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (6.98 KB, patch)
2019-09-24 06:28 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (6.98 KB, patch)
2019-09-24 06:33 PDT, Alex Christensen 		thorton: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2019-09-20 14:55:53 PDT
Created attachment 379273 [details] Patch
Alex Christensen
Comment 2 2019-09-20 23:04:04 PDT
Created attachment 379309 [details] Patch
EWS Watchlist
Comment 3 2019-09-20 23:04:36 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Carlos Garcia Campos
Comment 4 2019-09-23 02:47:46 PDT
Comment on attachment 379309 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379309&action=review > Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp:-331 > - if (!webkit_website_data_manager_is_ephemeral(priv->websiteDataManager.get())) > - configuration.setHSTSStorageDirectory(FileSystem::stringFromFileSystemRepresentation(webkit_website_data_manager_get_hsts_cache_directory(priv->websiteDataManager.get()))); I guess we still need to set this in LegacyGlobalSettings to keep it working for now.
Alex Christensen
Comment 5 2019-09-24 06:28:13 PDT
Created attachment 379443 [details] Patch
Alex Christensen
Comment 6 2019-09-24 06:29:35 PDT
All right. It would probably be beneficial for gtk to move it to not have anything to do with LegacyGlobalSettings, but that's your decision.
Alex Christensen
Comment 7 2019-09-24 06:33:42 PDT
Created attachment 379445 [details] Patch
Alex Christensen
Comment 8 2019-09-24 11:54:50 PDT
http://trac.webkit.org/r250312
Radar WebKit Bug Importer
Comment 9 2019-09-24 11:55:19 PDT
<rdar://problem/55671318>
Tim Horton
Comment 10 2019-09-24 16:33:35 PDT
This seems wrong for the case where there are multiple webkit clients in a given process
Note You need to log in before you can comment on or make changes to this bug.