Bug 202056 - Fix WPT test html/browsers/offline/application-cache-api/api_swapcache_error.https.html
Summary: Fix WPT test html/browsers/offline/application-cache-api/api_swapcache_error....
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-20 14:05 PDT by Alex Christensen
Modified: 2019-09-23 22:26 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.55 KB, patch)
2019-09-20 14:06 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (11.84 KB, patch)
2019-09-20 22:41 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (12.12 KB, patch)
2019-09-20 22:52 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (12.26 KB, patch)
2019-09-21 00:31 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2019-09-20 14:05:28 PDT 
null-check document in ApplicationCacheGroup::postListenerTask
Comment 1 Alex Christensen 2019-09-20 14:06:22 PDT 
Created attachment 379268 [details]
Patch
Comment 2 Alex Christensen 2019-09-20 14:06:44 PDT 
See https://build.webkit.org/results/Apple%20Mojave%20Release%20WK2%20(Tests)/r250139%20(6810)/results.html for an example of this crash.
Comment 3 Alexey Proskuryakov 2019-09-20 16:53:57 PDT 
Comment on attachment 379268 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379268&action=review

> Source/WebCore/ChangeLog:3
> +        null-check document in ApplicationCacheGroup::postListenerTask

Is this related to rdar://problem/55523986? A null check probably wouldn't be the right fix if it is.
Comment 4 Alex Christensen 2019-09-20 22:41:22 PDT 
Created attachment 379307 [details]
Patch
Comment 5 Alex Christensen 2019-09-20 22:52:58 PDT 
Created attachment 379308 [details]
Patch
Comment 6 Alex Christensen 2019-09-21 00:31:33 PDT 
Created attachment 379314 [details]
Patch
Comment 7 WebKit Commit Bot 2019-09-23 22:25:18 PDT 
Comment on attachment 379314 [details]
Patch

Clearing flags on attachment: 379314

Committed r250283: <https://trac.webkit.org/changeset/250283>
Comment 8 WebKit Commit Bot 2019-09-23 22:25:19 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-09-23 22:26:17 PDT 
<rdar://problem/55650495>