Bug 20205 - Typo in comment for bracer ending block
Summary: Typo in comment for bracer ending block
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Trivial
Assignee: Nobody
Depends on:
Reported: 2008-07-28 18:51 PDT by Gustavo Noronha (kov)
Modified: 2008-07-30 08:26 PDT (History)
0 users

See Also:

typo fix (920 bytes, patch)
2008-07-28 18:52 PDT, Gustavo Noronha (kov)
sam: review+
Details | Formatted Diff | Diff
tabs corrected (941 bytes, patch)
2008-07-29 06:37 PDT, Gustavo Noronha (kov)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo Noronha (kov) 2008-07-28 18:51:54 PDT
I believe the comment in webkitprivate.h is incorrect. I assure you this is not a way to have a patch of mine committed quickly for its simplicity =).

} /** end namespace WebCore */

should be 

} /** end namespace WebKit */
Comment 1 Gustavo Noronha (kov) 2008-07-28 18:52:36 PDT
Created attachment 22532 [details]
typo fix

patch to fix the issue
Comment 2 Sam Weinig 2008-07-28 22:16:11 PDT
Comment on attachment 22532 [details]
typo fix

r=me except you need to remove the tabs in the ChangeLog
Comment 3 Gustavo Noronha (kov) 2008-07-29 06:37:32 PDT
Created attachment 22536 [details]
tabs corrected

So, tabs fixed in the ChangeLog, should be OK to commit.
Comment 4 Gustavo Noronha (kov) 2008-07-29 06:38:31 PDT
Comment on attachment 22536 [details]
tabs corrected

I am adding the + flag, since it was already r=me'd =)
Comment 5 Sam Weinig 2008-07-29 07:28:06 PDT
Comment on attachment 22536 [details]
tabs corrected

Even though you already go this reviewed, if you post a second patch like this, you should still set the review flag to ?, as setting it to + will be confusing when committing the patch.
Comment 6 Christian Dywan 2008-07-30 08:26:23 PDT
Comment on attachment 22536 [details]
tabs corrected

Committed in r35447.