RESOLVED FIXED 20205
Typo in comment for bracer ending block 
https://bugs.webkit.org/show_bug.cgi?id=20205
Summary Typo in comment for bracer ending block
Gustavo Noronha (kov)
Reported 2008-07-28 18:51:54 PDT
I believe the comment in webkitprivate.h is incorrect. I assure you this is not a way to have a patch of mine committed quickly for its simplicity =). } /** end namespace WebCore */ should be } /** end namespace WebKit */
Attachments
typo fix (920 bytes, patch)
2008-07-28 18:52 PDT, Gustavo Noronha (kov) 		sam: review+
DetailsFormatted DiffDiff
tabs corrected (941 bytes, patch)
2008-07-29 06:37 PDT, Gustavo Noronha (kov) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gustavo Noronha (kov)
Comment 1 2008-07-28 18:52:36 PDT
Created attachment 22532 [details] typo fix patch to fix the issue
Sam Weinig
Comment 2 2008-07-28 22:16:11 PDT
Comment on attachment 22532 [details] typo fix r=me except you need to remove the tabs in the ChangeLog
Gustavo Noronha (kov)
Comment 3 2008-07-29 06:37:32 PDT
Created attachment 22536 [details] tabs corrected So, tabs fixed in the ChangeLog, should be OK to commit.
Gustavo Noronha (kov)
Comment 4 2008-07-29 06:38:31 PDT
Comment on attachment 22536 [details] tabs corrected I am adding the + flag, since it was already r=me'd =)
Sam Weinig
Comment 5 2008-07-29 07:28:06 PDT
Comment on attachment 22536 [details] tabs corrected Even though you already go this reviewed, if you post a second patch like this, you should still set the review flag to ?, as setting it to + will be confusing when committing the patch.
Christian Dywan
Comment 6 2008-07-30 08:26:23 PDT
Comment on attachment 22536 [details] tabs corrected Committed in r35447.
Note You need to log in before you can comment on or make changes to this bug.