Bug 202048 - ApplicationStateTracker::m_isBackground initialization does not account for UIScenes
Summary: ApplicationStateTracker::m_isBackground initialization does not account for U...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-20 09:14 PDT by Chris Dumez
Modified: 2019-09-20 16:59 PDT (History)
4 users (show)

See Also:


Attachments
Patch (4.47 KB, patch)
2019-09-20 09:15 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (4.88 KB, patch)
2019-09-20 11:20 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-09-20 09:14:27 PDT
ApplicationStateTracker::m_isBackground initialization does not account for UIScenes, it merely checks the visibility state of the whole app. It should instead check the visibility state of the window's UIScene.
Comment 1 Chris Dumez 2019-09-20 09:15:48 PDT
Created attachment 379245 [details]
Patch
Comment 2 Chris Dumez 2019-09-20 11:20:04 PDT
Created attachment 379248 [details]
Patch
Comment 3 Geoffrey Garen 2019-09-20 13:09:52 PDT
Comment on attachment 379248 [details]
Patch

r=me
Comment 4 Chris Dumez 2019-09-20 14:37:29 PDT
Comment on attachment 379248 [details]
Patch

Clearing flags on attachment: 379248

Committed r250154: <https://trac.webkit.org/changeset/250154>
Comment 5 Chris Dumez 2019-09-20 14:37:31 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-09-20 14:38:17 PDT
<rdar://problem/55572613>