Bug 202028 - Remove unused storage paths on APIProcessPoolConfiguration
Summary: Remove unused storage paths on APIProcessPoolConfiguration
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-19 22:22 PDT by Alex Christensen
Modified: 2019-09-20 13:13 PDT (History)
6 users (show)

See Also:

Attachments
Patch (31.76 KB, patch)
2019-09-19 22:24 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (31.84 KB, patch)
2019-09-19 22:38 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (32.88 KB, patch)
2019-09-19 22:48 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (32.65 KB, patch)
2019-09-19 23:38 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (32.85 KB, patch)
2019-09-19 23:54 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (32.85 KB, patch)
2019-09-19 23:55 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (33.41 KB, patch)
2019-09-20 05:24 PDT, Alex Christensen 		cdumez: review+
Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2019-09-19 22:22:49 PDT 
Remove unused storage paths on APIProcessPoolConfiguration
Comment 1 Alex Christensen 2019-09-19 22:24:32 PDT 
Created attachment 379205 [details]
Patch
Comment 2 Alex Christensen 2019-09-19 22:38:33 PDT 
Created attachment 379208 [details]
Patch
Comment 3 EWS Watchlist 2019-09-19 22:39:22 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 4 Alex Christensen 2019-09-19 22:48:58 PDT 
Created attachment 379211 [details]
Patch
Comment 5 Alex Christensen 2019-09-19 23:38:39 PDT 
Created attachment 379214 [details]
Patch
Comment 6 Alex Christensen 2019-09-19 23:54:04 PDT 
Created attachment 379216 [details]
Patch
Comment 7 Alex Christensen 2019-09-19 23:55:45 PDT 
Created attachment 379217 [details]
Patch
Comment 8 Alex Christensen 2019-09-20 05:24:11 PDT 
Created attachment 379232 [details]
Patch
Comment 9 Chris Dumez 2019-09-20 07:54:50 PDT 
Comment on attachment 379232 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379232&action=review

> Source/WebKit/NetworkProcess/cache/NetworkCache.h:173
> +    const String& storageDirectory() { return m_storageDirectory; }

Why isn’t this const?
Comment 10 Alex Christensen 2019-09-20 13:12:07 PDT 
It should be!
http://trac.webkit.org/r250143
Comment 11 Radar WebKit Bug Importer 2019-09-20 13:13:19 PDT 
<rdar://problem/55569594>