Bug 202027 - Remove some support for < iOS 13
Summary: Remove some support for < iOS 13
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-19 21:27 PDT by Keith Rollin
Modified: 2019-09-20 17:17 PDT (History)
4 users (show)

See Also:


Attachments
Patch (5.49 KB, patch)
2019-09-19 22:29 PDT, Keith Rollin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2019-09-19 21:27:13 PDT
Remove some support for iOS versions less than 13.0. 

Update conditionals that reference __IPHONE_OS_VERSION_MIN_REQUIRED and __IPHONE_OS_VERSION_MAX_ALLOWED, assuming that they both have values >= 130000. This means that expressions like "__IPHONE_OS_VERSION_MIN_REQUIRED < 101300" are always False and "__IPHONE_OS_VERSION_MIN_REQUIRED >= 101300" are always True.

After version checks have been removed, there are some cases where the preprocessor conditional looks like "#if PLATFORM(MAC) || PLATFORM(IOS_FAMILY)". These can be collapsed into "#if PLATFORM(COCOA)". This additional cleanup will be performed in a subsequent patch.

This removal is part of a series of patches effecting the removal of dead code for old versions of iOS. This particular pass involves changes in which Joe Pecoraro was involved. These changes are isolated from other similar changes in order to facilitate the reviewing process.
Comment 1 Radar WebKit Bug Importer 2019-09-19 21:27:28 PDT
<rdar://problem/55547109>
Comment 2 Keith Rollin 2019-09-19 22:29:07 PDT
Created attachment 379206 [details]
Patch
Comment 3 Alex Christensen 2019-09-19 22:46:42 PDT
Comment on attachment 379206 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379206&action=review

> Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h:222
> +#if PLATFORM(MAC) || PLATFORM(IOS_FAMILY)

These should just be PLATFORM(COCOA)
Comment 4 Keith Rollin 2019-09-19 22:55:08 PDT
I noted in my comment that I was going to perform that cleanup later. I'd like to keep each patch focussed on one type of change.
Comment 5 Keith Rollin 2019-09-20 12:53:34 PDT
So can I land it now anyway?
Comment 6 Alex Christensen 2019-09-20 13:19:56 PDT
I don't see any reason to do this in two changes.  It's not hard to follow, and it would merge cleanly if we merged this to a branch.
Comment 7 Keith Rollin 2019-09-20 14:06:24 PDT
My reason is that this current patch is part of a much larger body of work, and I don't want to distract myself by going down other paths at the point. I have a process to manage all these details. Getting to the change you want is part of that, but it comes later.
Comment 8 Alex Christensen 2019-09-20 14:08:21 PDT
Comment on attachment 379206 [details]
Patch

I'm assuming that means you have a long train of git commits that would need rebasing if we changed this.  Whatever.  You should have a work flow that is more open to review changing things.
Comment 9 WebKit Commit Bot 2019-09-20 17:17:34 PDT
Comment on attachment 379206 [details]
Patch

Clearing flags on attachment: 379206

Committed r250171: <https://trac.webkit.org/changeset/250171>
Comment 10 WebKit Commit Bot 2019-09-20 17:17:35 PDT
All reviewed patches have been landed.  Closing bug.