Bug 202020 – Web Inspector: searching in overrides doesn't work

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Konrad Dzwinel]

Created attachment 379187 [details]
no results for searching for 'Duck' within a document containing 'Duck' string

Steps to reproduce:
1. Open Web Inspector
2. Make sure that 'sources tab' is enabled in experiments
3. Use local overrides to override any text file (e.g. html) 
4. Open that file in 'Sources > Local Overrides'
5. Try searching with cmd+f for a string that exists within that text

Expected result:
Searched string is highlighted in text.

Actual result:
No search results are found.

[Joseph Pecoraro]

Created attachment 379194 [details]
[PATCH] Proposed Fix

[Devin Rousso]

Comment on attachment 379194 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=379194&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js:253
> +        if (this._sourceCode instanceof WI.LocalResource)

This is better than `isLocalResourceOverride` right?  Since it covers other local resources loaded via things like HAR as well, right?

[Joseph Pecoraro]

(In reply to Devin Rousso from comment #2)
> Comment on attachment 379194 [details]
> [PATCH] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=379194&action=review
> 
> r=me
> 
> > Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js:253
> > +        if (this._sourceCode instanceof WI.LocalResource)
> 
> This is better than `isLocalResourceOverride` right?  Since it covers other
> local resources loaded via things like HAR as well, right?

Correct

[WebKit Commit Bot]

Comment on attachment 379194 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 379194

Committed r250118: <https://trac.webkit.org/changeset/250118>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/55546309>