Bug 202006 – [iPadOS] The second click event is missing on double tap when dblclick handler is not present

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

rdar://problem/51706828

[zalan]

Created attachment 379165 [details]
Patch

[Wenson Hsieh]

Comment on attachment 379165 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379165&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2143
> +        return _positionInformation.nodeAtPositionHasDoubleClickHandler;

What is responsible for ensuring that position information is up to date here?

[zalan]

Comment on attachment 379165 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379165&action=review

>> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2143
>> +        return _positionInformation.nodeAtPositionHasDoubleClickHandler;
> 
> What is responsible for ensuring that position information is up to date here?

I was curious about that too and was going to figure that out myself! I had tested a few dynamic cases (add/remove eventlisteners) and they all worked fine so I thought I might just upload the patch first.

[Wenson Hsieh]

(In reply to zalan from comment #3)
> Comment on attachment 379165 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=379165&action=review
> 
> >> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2143
> >> +        return _positionInformation.nodeAtPositionHasDoubleClickHandler;
> > 
> > What is responsible for ensuring that position information is up to date here?
> 
> I was curious about that too and was going to figure that out myself! I had
> tested a few dynamic cases (add/remove eventlisteners) and they all worked
> fine so I thought I might just upload the patch first.

It would be worth double checking why this works. I suspect it's using position information state from web touch and/or text interaction gestures.

[zalan]

(In reply to Wenson Hsieh from comment #4)
> (In reply to zalan from comment #3)
> > Comment on attachment 379165 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=379165&action=review
> > 
> > >> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2143
> > >> +        return _positionInformation.nodeAtPositionHasDoubleClickHandler;
> > > 
> > > What is responsible for ensuring that position information is up to date here?
> > 
> > I was curious about that too and was going to figure that out myself! I had
> > tested a few dynamic cases (add/remove eventlisteners) and they all worked
> > fine so I thought I might just upload the patch first.
> 
> It would be worth double checking why this works. I suspect it's using
> position information state from web touch and/or text interaction gestures.
Absolutely. I was going to check if I need to trigger an update on eventlistner (de)registrations.

[zalan]

Created attachment 379272 [details]
Patch

[zalan]

Created attachment 379381 [details]
Patch

[Wenson Hsieh]

Comment on attachment 379381 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379381&action=review

> Source/WebKit/Shared/ios/InteractionInformationRequest.cpp:89
> -    return (other.point - point).diagonalLengthSquared() <= 4;
> +    return (other.point - point).diagonalLengthSquared() <= radius * radius;

Nit - it might be cleaner to just share code with InteractionInformationRequest::isValidForRequest above, by moving the distance check into InteractionInformationRequest::isValidForRequest and treating isValidForRequest as the case where radius == 0.

[zalan]

Created attachment 379468 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 379468 [details]
Patch

Clearing flags on attachment: 379468

Committed r250315: <https://trac.webkit.org/changeset/250315>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.