When JSC queue fails to build-jsc with the patch, it should re-build ToT and compare results to check if the failure is new or pre-existing.
Created attachment 379159 [details] Patch
Sample runs: - Failure introduced by patch: https://ews-build.webkit-uat.org/#/builders/17/builds/3989 - Failure on ToT: https://ews-build.webkit-uat.org/#/builders/17/builds/3985 - Success: https://ews-build.webkit-uat.org/#/builders/17/builds/3993, https://ews-build.webkit-uat.org/#/builders/17/builds/3935
Another sample run for 'success': https://ews-build.webkit-uat.org/#/builders/17/builds/3994
Note that this patch is only for building JSC, jsc-testing logic will be added/fixed in subsequent patches.
Comment on attachment 379159 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379159&action=review > Tools/BuildSlaveSupport/ews-build/factories.py:124 > self.addStep(UnApplyPatchIfRequired()) Is this not dynamically added as well?
Comment on attachment 379159 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379159&action=review >> Tools/BuildSlaveSupport/ews-build/factories.py:124 >> self.addStep(UnApplyPatchIfRequired()) > > Is this not dynamically added as well? These would be removed in subsequent patches. I haven’t started working on these tests yet.
Comment on attachment 379159 [details] Patch Clearing flags on attachment: 379159 Committed r250174: <https://trac.webkit.org/changeset/250174>
All reviewed patches have been landed. Closing bug.
<rdar://problem/55579180>