Bug 201999 - [EWS] JSC queues should re-build ToT and compare results on build failure
Summary: [EWS] JSC queues should re-build ToT and compare results on build failure
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-19 13:18 PDT by Aakash Jain
Modified: 2019-09-24 14:24 PDT (History)
7 users (show)

See Also:


Attachments
Patch (4.41 KB, patch)
2019-09-19 13:38 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-09-19 13:18:36 PDT
When JSC queue fails to build-jsc with the patch, it should re-build ToT and compare results to check if the failure is new or pre-existing.
Comment 1 Aakash Jain 2019-09-19 13:38:41 PDT
Created attachment 379159 [details]
Patch
Comment 3 Aakash Jain 2019-09-19 13:52:43 PDT
Another sample run for 'success': https://ews-build.webkit-uat.org/#/builders/17/builds/3994
Comment 4 Aakash Jain 2019-09-19 13:53:55 PDT
Note that this patch is only for building JSC, jsc-testing logic will be added/fixed in subsequent patches.
Comment 5 Jonathan Bedard 2019-09-19 16:29:33 PDT
Comment on attachment 379159 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379159&action=review

> Tools/BuildSlaveSupport/ews-build/factories.py:124
>          self.addStep(UnApplyPatchIfRequired())

Is this not dynamically added as well?
Comment 6 Aakash Jain 2019-09-19 17:37:32 PDT
Comment on attachment 379159 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379159&action=review

>> Tools/BuildSlaveSupport/ews-build/factories.py:124
>>          self.addStep(UnApplyPatchIfRequired())
> 
> Is this not dynamically added as well?

These would be removed in subsequent patches. I haven’t started working on these tests yet.
Comment 7 WebKit Commit Bot 2019-09-20 18:07:56 PDT
Comment on attachment 379159 [details]
Patch

Clearing flags on attachment: 379159

Committed r250174: <https://trac.webkit.org/changeset/250174>
Comment 8 WebKit Commit Bot 2019-09-20 18:07:57 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-09-20 18:08:15 PDT
<rdar://problem/55579180>