Bug 201989 - Refactoring: fix broken indentation in JSNonDestructibleProxy.h.
Summary: Refactoring: fix broken indentation in JSNonDestructibleProxy.h.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-19 09:53 PDT by Mark Lam
Modified: 2019-09-19 12:03 PDT (History)
7 users (show)

See Also:


Attachments
proposed patch. (6.65 KB, patch)
2019-09-19 09:56 PDT, Mark Lam
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2019-09-19 09:53:11 PDT
...
Comment 1 Mark Lam 2019-09-19 09:56:26 PDT
Created attachment 379139 [details]
proposed patch.
Comment 2 Saam Barati 2019-09-19 10:13:54 PDT
Comment on attachment 379139 [details]
proposed patch.

I thought we tried to avoid changes like this, even when the prior code didn't conform to WK style?
Comment 3 Mark Lam 2019-09-19 10:37:41 PDT
We do do these kinds of refactoring as a separate patch.  For example, see:

2014: https://trac.webkit.org/r173269 many files
      https://trac.webkit.org/r171606 PropertyNameArray.h
      https://trac.webkit.org/r166278 Heap.h
2013: https://trac.webkit.org/r143171 JSGlobalObject.h and JSGlobalObjectFunctions.h
Comment 4 Mark Lam 2019-09-19 10:59:31 PDT
Comment on attachment 379139 [details]
proposed patch.

Thanks for the review.
Comment 5 WebKit Commit Bot 2019-09-19 12:02:12 PDT
Comment on attachment 379139 [details]
proposed patch.

Clearing flags on attachment: 379139

Committed r250099: <https://trac.webkit.org/changeset/250099>
Comment 6 WebKit Commit Bot 2019-09-19 12:02:13 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-09-19 12:03:20 PDT
<rdar://problem/55528429>