Bug 201982 - [GTK][WPE] EXIF orientation tests are failing since added in r249364 - "EXIF orientation should be respected when rendering images"
Summary: [GTK][WPE] EXIF orientation tests are failing since added in r249364 - "EXIF ...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 95299
Blocks:
  Show dependency treegraph
 
Reported: 2019-09-19 06:54 PDT by Miguel Gomez
Modified: 2022-05-09 01:11 PDT (History)
8 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Miguel Gomez 2019-09-19 06:54:37 PDT
These are the tests failing both for WPE and GTK.

fast/images/exif-orientation-background.html [ ImageOnlyFailure ]
fast/images/exif-orientation-canvas.html [ ImageOnlyFailure ]
fast/images/exif-orientation-composited.html [ ImageOnlyFailure ]
fast/images/exif-orientation-content.html [ ImageOnlyFailure ]
fast/images/exif-orientation-element-object-fit.html [ ImageOnlyFailure ]
fast/images/exif-orientation-element.html [ ImageOnlyFailure ]
fast/images/exif-orientation-image-document.html [ ImageOnlyFailure ]
fast/images/exif-orientation-image-object.html [ ImageOnlyFailure ]
fast/images/exif-orientation-svg-feimage.html [ ImageOnlyFailure ]
fast/images/exif-orientation-svg-image.html [ ImageOnlyFailure ]

These is the output of one of the tests that shows the problem:
https://build.webkit.org/results/WPE%20Linux%2064-bit%20Release%20(Tests)/r250087%20(15371)/fast/images/exif-orientation-element-diffs.html

Seems that we are not calculating the proper width and height for images rotated 90 degrees CW and CCW.
Comment 1 Diego Pino 2020-01-09 06:22:18 PST
New EXIF related tests are failing showing the same kind of error message: "EXIF orientation should be respected". The tests are the following:

Since added in r253610:

* fast/images/exif-orientation-webgl-texture.html

Since added in r254187:

* fast/images/image-orientation-dynamic-from-image.html
* fast/images/image-orientation-dynamic-none.html
* fast/images/image-orientation-none.html
Comment 2 Diego Pino 2020-01-22 08:53:16 PST
More EXIF orientation related tests are failing since added in r254841:
 
  * fast/images/exif-orientation-background-image-no-repeat.html
  * fast/images/exif-orientation-background-image-repeat.html
  * fast/images/exif-orientation-border-image.html
Comment 3 Lauro Moura 2020-04-06 22:02:25 PDT
This is also affecting fast/images/image-orientation-none-canvas.html from bug209849.
Comment 4 Diego Pino 2020-04-14 05:03:51 PDT
Passing since r260016 (https://trac.webkit.org/changeset/260050/webkit):

  fast/images/image-orientation-dynamic-none.html
  fast/images/image-orientation-none.html
  fast/images/image-orientation-none-canvas.html
Comment 5 Michael Catanzaro 2020-10-08 06:03:23 PDT
Lauro fixed most of these (but not all) in bug #95299.
Comment 6 Lauro Moura 2020-10-08 06:07:56 PDT
(In reply to Michael Catanzaro from comment #5)
> Lauro fixed most of these (but not all) in bug #95299.

Thanks for applying #95299, Michael (did not have time due to other issues). It's on my table today to update what's missing from that bug.
Comment 7 Lauro Moura 2020-10-08 20:17:25 PDT
Remaining issues after bug95299:

fast/images/exif-orientation-background-image-repeat.html
fast/images/exif-orientation-border-image.html

Summary of failures:

fast/images/exif-orientation-background-image-repeat.html

* No orientation applied when:
  * Flipped horizontally
  * Flipped vertically
  * Rotated 180°
  * Rotated 90° CCW
* "Translated" halfway to the left
  * Rotated 90° CW
  * Rotated 90° CCW and flipped vertically
  * Rotated 90° CW and flipped vertically

fast/images/exif-orientation-border-image.html

* Corrupted border:
  * All 90° rotations
* Some sections not transformed
  * Flipped horizontally
  * Flipped vertically
  * Rotated 180°
Comment 8 Dawn Morningstar 2022-03-07 15:43:59 PST
fast/images/exif-orientation-background-image-repeat.html
is still a failure, expectation may need to be set to clear up dashboard until this issue is resolved
Comment 9 Milan Crha 2022-05-09 01:10:33 PDT
Downstream bug report using WebKitGTK 2.36.0:
https://gitlab.gnome.org/GNOME/evolution/-/issues/1897

it includes a sample image, if needed.
Comment 10 Milan Crha 2022-05-09 01:11:21 PDT
I see this is marked as WPE; I'm not sure it's related for the evolution bug.