Bug 201948 - Web Inspector: console assertion when pressing up/down in empty console log view
Summary: Web Inspector: console assertion when pressing up/down in empty console log view
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-18 15:04 PDT by Joseph Pecoraro
Modified: 2019-09-18 18:46 PDT (History)
4 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (2.96 KB, patch)
2019-09-18 17:17 PDT, Joseph Pecoraro 		hi: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2019-09-18 15:04:51 PDT 
console assertion when pressing up/down in empty console log view

Steps to Reproduce:
1. Open Web Inspector
2. js> 123
3. Select the "123" output view
4. Clear the console (⌘K)
5. Press Up or Down
  => Assert in inspector²

Notes:
Simple fix, but maybe we should beep.
Comment 1 Joseph Pecoraro 2019-09-18 17:17:02 PDT 
Created attachment 379088 [details]
[PATCH] Proposed Fix
Comment 2 Devin Rousso 2019-09-18 17:25:22 PDT 
Comment on attachment 379088 [details]
[PATCH] Proposed Fix

rs=me

Can you actually write somewhere what the assertion message/location actually was?  I'm guessing it's the `console.assert(message)` inside `WI.LogContentView.prototype._updateMessagesSelection`?
Comment 3 Joseph Pecoraro 2019-09-18 17:34:32 PDT 
(In reply to Devin Rousso from comment #2)
> Comment on attachment 379088 [details]
> [PATCH] Proposed Fix
> 
> rs=me
> 
> Can you actually write somewhere what the assertion message/location
> actually was?  I'm guessing it's the `console.assert(message)` inside
> `WI.LogContentView.prototype._updateMessagesSelection`?

Yep that was it. I'll add that to the ChangeLog.
Comment 4 Joseph Pecoraro 2019-09-18 18:45:56 PDT 
https://trac.webkit.org/r250076
Comment 5 Radar WebKit Bug Importer 2019-09-18 18:46:19 PDT 
<rdar://problem/55502716>