Bug 201921 – NetworkLoadParameters shouldn't store sessionID

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Ben Nham]

Now that there's a single session id per WebProcess, we don't need to store the session id in NetworkLoadParameters anymore. Clients can just directly ask NetworkConnectionToWebProcess for the WebProcess's session ID instead.

[Ben Nham]

Created attachment 379055 [details]
Patch

[Chris Dumez]

Comment on attachment 379055 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379055&action=review

> Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.cpp:-120
> -    if (!decoder.decode(result.identifier))

Didn't you drop this one by mistake?

[Ben Nham]

Created attachment 379057 [details]
Patch

[Ben Nham]

Yep, I deleted the extra line in the decoding function which broke website loading completely. Should be fixed in the newest patch.

[Chris Dumez]

Comment on attachment 379057 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379057&action=review

r=me with nits.

> Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:304
> +    auto* networkSession = m_connection->networkProcess().networkSession(sessionID());

I believe this could be:
auto* networkSession = m_connection->networkSession();

> Source/WebKit/NetworkProcess/PreconnectTask.h:43
> +    explicit PreconnectTask(NetworkProcess&, PAL::SessionID, NetworkLoadParameters&&, CompletionHandler<void(const WebCore::ResourceError&)>&& completionHandler = { });

nit: we should probably drop the explicit.

[Ben Nham]

Created attachment 379061 [details]
Patch

[Chris Dumez]

Let's wait for green bubbles before committing.

[WebKit Commit Bot]

Comment on attachment 379061 [details]
Patch

Clearing flags on attachment: 379061

Committed r250053: <https://trac.webkit.org/changeset/250053>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/55493060>