RESOLVED FIXED 201920
CacheStorageProvider::createCacheStorageConnection() does not need to take in a SessionID 
https://bugs.webkit.org/show_bug.cgi?id=201920
Summary CacheStorageProvider::createCacheStorageConnection() does not need to take in...
Chris Dumez
Reported 2019-09-18 09:58:35 PDT
CacheStorageProvider::createCacheStorageConnection() does not need to take in a SessionID. This sessionID is no longer used now that we have a session per WebProcess.
Attachments
Patch (31.32 KB, patch)
2019-09-18 10:00 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (32.68 KB, patch)
2019-09-18 10:41 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2019-09-18 10:00:26 PDT
Created attachment 379047 [details] Patch
Geoffrey Garen
Comment 2 2019-09-18 10:10:24 PDT
Comment on attachment 379047 [details] Patch r=me
Chris Dumez
Comment 3 2019-09-18 10:41:12 PDT
Created attachment 379048 [details] Patch
Chris Dumez
Comment 4 2019-09-18 11:37:17 PDT
Comment on attachment 379048 [details] Patch Clearing flags on attachment: 379048 Committed r250045: <https://trac.webkit.org/changeset/250045>
Chris Dumez
Comment 5 2019-09-18 11:37:19 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-09-18 11:38:19 PDT
<rdar://problem/55486406>
Ross Kirsling
Comment 7 2019-09-18 14:24:51 PDT
This broke WinCairo again...
Chris Dumez
Comment 8 2019-09-18 14:25:21 PDT
(In reply to Ross Kirsling from comment #7) > This broke WinCairo again... wincairo EWS has been dead for several days...
Ross Kirsling
Comment 9 2019-09-18 14:27:28 PDT
(In reply to Chris Dumez from comment #8) > (In reply to Ross Kirsling from comment #7) > > This broke WinCairo again... > > wincairo EWS has been dead for several days... Really? The EWS error message here is correct though, just as it was in bug 201881.
Chris Dumez
Comment 10 2019-09-18 14:28:39 PDT
(In reply to Ross Kirsling from comment #9) > (In reply to Chris Dumez from comment #8) > > (In reply to Ross Kirsling from comment #7) > > > This broke WinCairo again... > > > > wincairo EWS has been dead for several days... > > Really? The EWS error message here is correct though, just as it was in bug > 201881. Oh, maybe it is fixed now. What I have been seeing for a while was: https://ews-build.webkit.org/#/builders/12/builds/4770 So I started ignoring that bot. Sorry.
Chris Dumez
Comment 11 2019-09-18 14:33:22 PDT
<https://trac.webkit.org/changeset/250054>
Ross Kirsling
Comment 12 2019-09-18 14:50:36 PDT
(In reply to Chris Dumez from comment #10) > Oh, maybe it is fixed now. What I have been seeing for a while was: > https://ews-build.webkit.org/#/builders/12/builds/4770 > > So I started ignoring that bot. Sorry. Ah right, I knew that had been happening intermittently but perhaps it's been worse than I realized. It would be great if we were able get that particular issue fixed more permanently...
Note You need to log in before you can comment on or make changes to this bug.