Bug 201916 - Drop FrameLoaderClient::sessionID()
Summary: Drop FrameLoaderClient::sessionID()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-18 08:33 PDT by Chris Dumez
Modified: 2019-09-18 10:41 PDT (History)
9 users (show)

See Also:


Attachments
Patch (13.22 KB, patch)
2019-09-18 08:36 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (14.63 KB, patch)
2019-09-18 09:14 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-09-18 08:33:50 PDT
Drop FrameLoaderClient::sessionID(). The Frame can get the sessionID from its page (Which is what the FrameLoaderClient::sessionID() ended up doing) and other call sites at WebKit2 layer can get the sessionID from the WebProcess singleton.
Comment 1 Chris Dumez 2019-09-18 08:36:07 PDT
Created attachment 379039 [details]
Patch
Comment 2 Chris Dumez 2019-09-18 09:14:14 PDT
Created attachment 379041 [details]
Patch
Comment 3 Geoffrey Garen 2019-09-18 10:09:37 PDT
Comment on attachment 379041 [details]
Patch

r=me
Comment 4 Chris Dumez 2019-09-18 10:14:20 PDT
Comment on attachment 379041 [details]
Patch

Clearing flags on attachment: 379041

Committed r250043: <https://trac.webkit.org/changeset/250043>
Comment 5 Chris Dumez 2019-09-18 10:14:22 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-09-18 10:15:19 PDT
<rdar://problem/55482907>
Comment 7 Radar WebKit Bug Importer 2019-09-18 10:15:23 PDT
<rdar://problem/55482910>