Bug 20191 – [Qt] Hitting enter/return doesn't create new list items as in other WebKit ports.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Erik L. Bunce]

This problem still exists in SVN r35406.

Creating either an ordered or unordered list in (TinyMCE, RTEF, or otherwise) doesn't work as expected using the Qt build of WebKit.  In Safari and using the Mac OS X native build, Enter/Return result in a new list item being created, however it inserts a line break.

This is caused by the VK_RETURN handling in Qt WebKit  calling the InsertLineBreak instead of InsertNewline command.

[Erik L. Bunce]

Created attachment 22516 [details]
Patch to change VK_RETURN handling from InsertLineBreak to InsertNewline

[Tor Arne Vestbø]

This should probably be handled in QWebPage::editorActionForKeyEvent(), but might require changes in Qt. I'm looking into it.

We also need to make sure we exec InsertLineBreak when the shift modifier is pressed (ctrl on mac).

[Erik L. Bunce]

I agree about the Shift / CTRL modifier.  Also that long-term a lot of EditorClientQt::handleKeyboardEvent() should be refactored, and that comparison/dispatch using QKeySequence would be a better way to go. However, I'm not sure wholesale moving it to use QWebPage::editorActionForKeyEvent() is the correct solution either, unless you wish to expose most / all of the necessary commands as QWebPage::WebActions.

[Erik L. Bunce]

Created attachment 22523 [details]
Improved patch handles Shift + Return properly.

[Erik L. Bunce]

Looking at the sequences in question, making them QPage::WebActions might not be a bad idea.

I'd still probably separate the edit vs. 'nav' action lookups.

[Tor Arne Vestbø]

Preliminary patch (requires a > 1. August Qt snapshot):

http://code.staikos.net/cgi-bin/gitweb.cgi?p=webkit;a=commitdiff;h=fb313a86b2565637593c8b5b497c28b9ae763b1a

[Tor Arne Vestbø]

Updated patch. This one should build against Qt 4.4 too (by using the approach of patch 22523). Thanks for contributing!

http://code.staikos.net/cgi-bin/gitweb.cgi?p=webkit;a=commitdiff;h=7d2f6e54672ca4d0c3fd4541ad59e4f32db981cc

[Erik L. Bunce]

Heh, the one correction I'd make is that my name is Erik with a k at the end.  ;-)

[Tor Arne Vestbø]

Landed in r35558, with a k at the end :)

Thanks!