In macOS 10.15 and iOS 13.0 SDKs, the keyPackage parameter of CCECCryptorImportKey() was changed from "void*" to "const void*". This change was accounted for in Bug 195754 by making the same change to the parallel declarations in CommonCryptoSPI.h. But since this header also needed to be used in macOS 10.14 contexts, the old declaration was also kept. But since this function is a "C" function, the types of parameters are not included in the function signature, and it doesn't really matter what parameter types are, so long as the right values are sent to the called function. This means that we don't need two versions of the function, one with a "const" parameter and one without. We only really need one. In this case, it makes sense to keep the more-restrictive one -- the with a "const void*" parameter. Therefore, remove the one taking just "void*".
<rdar://problem/55466589>
Created attachment 379018 [details] Patch
Comment on attachment 379018 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379018&action=review > Source/WebCore/PAL/ChangeLog:3 > + Remove alternate declaration of CCECCryptorImportKey This change is a local improvement, however this whole file isn’t following our normal convention. Normally, we redeclare functions in internal builds to catch changes in signatures, which can be more drastic than here.
Comment on attachment 379018 [details] Patch Clearing flags on attachment: 379018 Committed r250049: <https://trac.webkit.org/changeset/250049>
All reviewed patches have been landed. Closing bug.