Bug 201889 - Follow-up after String.codePointAt optimization
Summary: Follow-up after String.codePointAt optimization
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-17 16:36 PDT by Yusuke Suzuki
Modified: 2019-09-17 17:31 PDT (History)
7 users (show)

See Also:

Attachments
Patch (13.57 KB, patch)
2019-09-17 16:38 PDT, Yusuke Suzuki 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2019-09-17 16:36:58 PDT 
Follow-up after String.codePointAt optimization
Comment 1 Yusuke Suzuki 2019-09-17 16:38:32 PDT 
Created attachment 379006 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2019-09-17 16:39:23 PDT 
<rdar://problem/55459325>
Comment 3 Yusuke Suzuki 2019-09-17 16:41:15 PDT 
Comment on attachment 379006 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379006&action=review

> Source/JavaScriptCore/ChangeLog:11
> +        2. Check BadType in String.codePointAt, String.charAt, and String.charCodeAt.

For now, I'm just fixing these three things. It would be profitable to see the other things, but it involves more changes (like, check whether it accepts UntypedUse etc.).
Comment 4 Yusuke Suzuki 2019-09-17 17:31:56 PDT 
Committed r250004: <https://trac.webkit.org/changeset/250004>